Issue metadata
Sign in to add a comment
|
Regression:Video on first tab doesn't play in its original size after entering PIP mode on second tab. |
||||||||||||||||||||||
Issue descriptionChrome Version : 73.0.3670.0 (Official Build) Revision 1ad472e9f385f6769ab1d1709a2ba26218522c96-refs/branch-heads/3670@{#1} (32/64 bit) OS : Windows 10 Test URL : http://googlechrome.github.io/samples/picture-in-picture What steps will reproduce the problem? 1. Fresh launch chrome, open 2 NTPs and navigate to above test URL from both the NTPs. 2. Play the video on first NTP and click on the 'Picture-in-Picture' option from 3 dot menu. 3. Play the video on second NTP, and click on the 'Picture-in-Picture' option from 3 dot menu. 4. Go back to first NTP and observe the video. Actual Result : Video on the first tab does not play in its original size after entering picture-in-picture mode on the second tab. Expected Result : Video on the first tab should in its original size even after entering picture-in-picture mode on the second tab. This is a regression issue broken in M-73 and below is the per-revision bisect information: Good Build : 73.0.3668.0 (Revision : 621860) Bad Build : 73.0.3669.0 (Revision : 622247) You are probably looking for a change made after 622001 (known good), but no later than 622002 (first known bad). CHANGE-LOG URL The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9c14227e998c49fe237f2a4eec796aab02faeda8..4ccb547b7ff46b30a7a8fcc59e2ecc8f1094fef4 Suspect: https://chromium.googlesource.com/chromium/src/+/4ccb547b7ff46b30a7a8fcc59e2ecc8f1094fef4 @beaufort.francois: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer attached screen cast. Note: 1. Issue is specific to Win 10 OS. 2. Unable to reproduce the issue on below links, - https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html - https://www.quirksmode.org/html5/tests/video.html
,
Jan 14
Seems like a compositing issue.
,
Jan 14
Sure, I can take a look.
,
Jan 14
I cannot repro this on Windows 10 at r622614. I went back and forth in two tabs and kept setting the active tab to PIP mode and the video in the older tab always played at the correct resolution. Do you have any other advice on how to repro?
,
Jan 15
Could not repro at r622247 either.
,
Jan 15
Update: Above issue is still reproducible on Win 10 OS using latest Canary build #73.0.3672.0.(Kindly refer attached screen cast) Re-bisected the above issue again using per-revision bisect and it is still providing the same suspect. https://chromium.googlesource.com/chromium/src/+log/9c14227e998c49fe237f2a4eec796aab02faeda8..4ccb547b7ff46b30a7a8fcc59e2ecc8f1094fef4 Suspect: https://chromium.googlesource.com/chromium/src/+/4ccb547b7ff46b30a7a8fcc59e2ecc8f1094fef4 @beaufort.francois : Requesting you to kindly check again whether this is caused with respect to your change Thank you
,
Jan 15
I cannot repro this on canary either. Due to persistent bisects to the same revision, assigning back to beaufort.francois to try to repro.
,
Jan 17
(5 days ago)
I should add that I'm happy to help debug or suggest ideas, but I do not feel like I can do anything without a local repro at this point.
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e27cee0958bb04cd14067c4a2b1eeca4b8b9f64 commit 0e27cee0958bb04cd14067c4a2b1eeca4b8b9f64 Author: François Beaufort <beaufort.francois@gmail.com> Date: Fri Jan 18 13:21:35 2019 Don't throttle hidden tab in Picture-in-Picture This CL makes sure a tab is not throttled when hidden if it has a Picture-in-Picture video. Renderer is still informed though that the tab was hidden. Bug: 917303, 921460 , 921478 Change-Id: Ia0c5c4841b48d8f62f8ddbc12653522e0b59f6b5 Reviewed-on: https://chromium-review.googlesource.com/c/1419841 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#624096} [modify] https://crrev.com/0e27cee0958bb04cd14067c4a2b1eeca4b8b9f64/content/browser/web_contents/web_contents_impl.cc
,
Jan 18
(4 days ago)
I cannot reproduce either latest Chromium build on macOS 73.0.3677. vineethas@ Can you still reproduce?
,
Yesterday
(45 hours ago)
,
Yesterday
(44 hours ago)
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fbeaufort@chromium.org
, Jan 14