Issue 921455 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	rbpotter@chromium.org
Closed:	Jan 16
Cc:	nyerramilli@chromium.org rbasuvula@chromium.org
Components:	UI>Browser>History
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Mac
Pri:	1
Type:	Bug-Regression
hasbisect-per-revision ET-MUM-Reported M-73 RegressedIn-73 Target-73 FoundIn-73

Regression: Broken UI for chrome://history page is seen after reloading page.

Project Member Reported by dipt...@virtusa.com, Jan 14

Issue description

Chrome Version: 73.0.3670.0 Revision 1ad472e9f385f6769ab1d1709a2ba26218522c96-refs/branch-heads/3670@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10, Linux(14.04 LTS) and Mac(10.13.6,10.14.3,1014.6) 

Pre-Condition: Create some history by navigating to google apps.

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history page. 
(2) Click on 'Actions' icon of any URL and click on 'More from this site'
(3) Reload page and observe.

Actual: Broken UI for chrome://history page is seen after reloading page.

Expected: UI of chrome://history page should seen properly.

This is a regression issue, broken in 'M73', will soon update the other info:

Good Build:73.0.3634.0
Bad Build: 73.0.3635.0

	Actual_UI.mp4 458 KB View Download

	Expected_UI.mp4 317 KB View Download

Comment 1 by dipt...@virtusa.com, Jan 14

Labels: hasbisect-per-revision
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)

You are probably looking for a change made after 614934(known good), but no later than 614935(first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/80d1f9a53edb2cd5aea5807589c83f4b0b84607e..8590a077110d1cc40a70fe053f76f0056569027c

Suspect: https://chromium.googlesource.com/chromium/src/+/8590a077110d1cc40a70fe053f76f0056569027c

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thank You.

Comment 2 by dipt...@virtusa.com, Jan 14

Labels: -Type-Bug Type-Bug-Regression

Comment 3 by rbpotter@chromium.org, Jan 14

Status: Started (was: Assigned)

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c11e3b90b874ba5577d9ad45206287b7ce83a2e

commit 2c11e3b90b874ba5577d9ad45206287b7ce83a2e
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jan 16 04:24:36 2019

History UI: Check for undefined property in observer

Bug:  921455 
Change-Id: I97bf75144fa9fdfbfed9a207f1b41948578df2cc
Reviewed-on: https://chromium-review.googlesource.com/c/1410013
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623098}
[modify] https://crrev.com/2c11e3b90b874ba5577d9ad45206287b7ce83a2e/chrome/browser/resources/md_history/searched_label.js
[modify] https://crrev.com/2c11e3b90b874ba5577d9ad45206287b7ce83a2e/chrome/test/data/webui/md_history/md_history_browsertest.js
[add] https://crrev.com/2c11e3b90b874ba5577d9ad45206287b7ce83a2e/chrome/test/data/webui/md_history/searched_label_test.js

Comment 5 by rbpotter@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Started)

►

Issue 921455 link

Issue metadata

Regression: Broken UI for chrome://history page is seen after reloading page.

Issue description

Comment 1 by dipt...@virtusa.com, Jan 14

Comment 1 Deleted

Comment 2 by dipt...@virtusa.com, Jan 14

Comment 2 Deleted

Comment 3 by rbpotter@chromium.org, Jan 14

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jan 16

Comment 4 Deleted

Comment 5 by rbpotter@chromium.org, Jan 16 (6 days ago)

Comment 5 Deleted

Sign in to add a comment