New issue
Advanced search Search tips

Issue 921445 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 898810
Owner:
Closed: Jan 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert chrome/browser/ui/webui/settings/people_handler.cc to IdentityManager

Project Member Reported by gyuyo...@igalia.com, Jan 14

Issue description

API used in people_handler.cc:
- SigninManager::SignOut()
- SigninManager::IsAuthenticated()
- SigninManager::SignOutAndRemoveAllAccounts()
- SigninManager::IsSigninAllowed()
 
Mergedinto: 898810
Status: Duplicate (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cacfd35f4e09cbbd969a2c882f3db0eccc127bc0

commit cacfd35f4e09cbbd969a2c882f3db0eccc127bc0
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Wed Jan 16 10:36:33 2019

Migrate PeopleHandler to the IdentityManager

Use the APIs from IdentityManager and PrimaryAccountsMutator to migrate
calls previously depending on SigninManager and ProfileOAuth2TokenService.

Bug:  898810 ,  920236 ,  920237 ,  921445 
Change-Id: I22b046bae82e2539d165d95573c27d47affa6a06
Reviewed-on: https://chromium-review.googlesource.com/c/1298994
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623185}
[modify] https://crrev.com/cacfd35f4e09cbbd969a2c882f3db0eccc127bc0/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/cacfd35f4e09cbbd969a2c882f3db0eccc127bc0/chrome/browser/ui/webui/settings/people_handler_unittest.cc

Sign in to add a comment