New issue
Advanced search Search tips

Issue 921437 link

Starred by 3 users
Status: Verified
Owner:
collinbaker@chromium.org
Closed: Jan 16
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Extension icon is not properly aligned inside wrench menu

Project Member Reported by sany...@virtusa.com, Jan 14 
Chrome version: 73.0.3670.0 (Official Build) Revision	1ad472e9f385f6769ab1d1709a2ba26218522c96-refs/branch-heads/3670@{#1} (32/64-bit)
OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.3) 

What steps will reproduce the problem?
(1) Launch chrome and install any extension from Chrome Web Store (extension will get installed in toolbar).
(2) Now drag the toolbar so extension shifts to wrench menu.
(3) Observe.

Actual Result: 1.Extension icon is not properly aligned inside wrench menu.
               2.Also observe that on hovering mouse on extension icon, focus is seen chopped from LHS.

Expected Result: 1.Extension icon should be properly aligned inside wrench menu
                 2.On mouse hover on extension icon, focus should not be seen chopped.

This is a regression issue broken in ‘M-73’,and will soon update the bisect info:
Good build: 73.0.3668.0 (Revision: 621860)
Bad build:  73.0.3669.0 (Revision: 622247)

Kindly refer the attached screen-cast.

Thank You..!!
Actual Result.mov
1.2 MB View Download
Expected Result.mov
1.6 MB View Download

Comment 1 by sany...@virtusa.com, Jan 14

Labels: hasbisect-per-revision
Owner: collinbaker@chromium.org
Status: Assigned (was: Unconfirmed)
Update:
You are probably looking for a change made after 622189 (known good), but no later than 622190 (first known bad).

CHANGE-LOG URL

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/045eddcd250fbc7622da5dff12bdfb083a27e947..dfeb060f50d5041e480d2f008cebb17d5307ad19

Suspect: https://chromium.googlesource.com/chromium/src/+/dfeb060f50d5041e480d2f008cebb17d5307ad19

@Collin: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 1.Issue is also seen on latest canary #73.0.3671.0
      2.Issue is not reproducible on Linux (14.04 LTS)
Thank You..!

Comment 2 by meh...@chromium.org, Jan 14

Components: UI>Browser>Core
Labels: ReleaseBlock-Stable

Comment 3 by collinbaker@chromium.org, Jan 14

Status: Started (was: Assigned)
This is definitely me.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cb419c155a9940c61bee16660b4ea22261fc74

commit 64cb419c155a9940c61bee16660b4ea22261fc74
Author: Collin Baker <collinbaker@chromium.org>
Date: Tue Jan 15 02:55:22 2019

Fix extension overflow icon layout regression

On Linux, a menu layout is performed after the AppMenu::RunMenu
call. On Windows, this is not the case so a layout of the parent
MenuItemView must be forced.

Bug:  921437 
Change-Id: I2430da71d9d073e9d2cba880af3b01c68626fecb
Reviewed-on: https://chromium-review.googlesource.com/c/1410102
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622693}
[modify] https://crrev.com/64cb419c155a9940c61bee16660b4ea22261fc74/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc

Comment 5 by sany...@virtusa.com, Jan 16 (6 days ago)

Labels: TE-Verified-M73 TE-Verified-73.0.3673.0
Update:

Retested the above issue on Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.3)using latest Beta build #72.0.3626.64 and Canary build #73.0.3673.0 and issue is fixed.

Kindly refer the attached screen-cast.

Thank You!
Fixed Result.mov
1.2 MB View Download

Comment 6 by collinbaker@chromium.org, Jan 16 (6 days ago)

Status: Verified (was: Started)
►

Sign in to add a comment