New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 921423 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Get rid of extra copy for ExamplePreprocessor

Project Member Reported by charleszhao@chromium.org, Jan 14

Issue description

Current ExamplePreprocessor keeps a copy of config inside which is unnecessary. https://cs.chromium.org/chromium/src/components/assist_ranker/example_preprocessing.h


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a9e8e49d66e65396719ea52df92e83e5bb892ee

commit 5a9e8e49d66e65396719ea52df92e83e5bb892ee
Author: Charles Zhao <charleszhao@chromium.org>
Date: Tue Jan 15 04:55:31 2019

assist_ranker: make ExamplePreprocessor static

(1) Delete ExamplePreprocessorConfig inside ExamplePreprocessor,
    instead take config as input directly.
(2) Fixed all places that use ExamplePreprocessor.

Bug: crbug.com/921423
Change-Id: I98fabd116f7941a41d0dadaacafaa2a20937ddb2
Reviewed-on: https://chromium-review.googlesource.com/c/1408730
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622736}
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/chrome/browser/chromeos/power/ml/smart_dim/model_impl.cc
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/chrome/browser/chromeos/power/ml/smart_dim/model_impl.h
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.cc
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.h
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/components/assist_ranker/example_preprocessing.cc
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/components/assist_ranker/example_preprocessing.h
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/components/assist_ranker/example_preprocessing_unittest.cc
[modify] https://crrev.com/5a9e8e49d66e65396719ea52df92e83e5bb892ee/components/assist_ranker/generic_logistic_regression_inference.cc

Sign in to add a comment