New issue
Advanced search Search tips

Issue 921416 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Binary size reports should not contain unwind_cfi_32

Project Member Reported by agrieve@chromium.org, Jan 14

Issue description

This is a file that:
 * Is included only for Canary & Dev builds
 * Changes in size with every commit that affects native code.

We created a quick-fix to filter out the symbol when looking at official releases:
https://cs.chromium.org/chromium/src/tools/binary_size/libsupersize/static/index.html?rcl=c32044fc3ac8ac2c9d2473882819d580cad95efc&l=128

However, we also need a solution to reduce the noise it's causing for android-binary-size trybot.

Proposed solution:
1) Create a GN arg that can disable it. Set it for android-binary-size & diagnose_bloat.py
2) Change official builds to measure the Stable .apk rather than the non-channel builds.
 

Comment 1 by agrieve@chromium.org, Yesterday (38 hours ago)

Labels: binary_size_team_q1_2019

Sign in to add a comment