New issue
Advanced search Search tips

Issue 921338 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue angleproject:3014



Sign in to add a comment

ASSERT: mDirtyAttribBits[0].none()

Project Member Reported by ClusterFuzz, Jan 12

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4906149782224896

Fuzzer: libFuzzer_gpu_angle_fuzzer
Fuzz target binary: gpu_angle_fuzzer
Job Type: x86_libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  mDirtyAttribBits[0].none()
  gl::VertexArray::syncState
  gl::State::syncVertexArray
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=x86_libfuzzer_chrome_asan_debug&range=622253:622274

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4906149782224896

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.
 
Project Member

Comment 1 by ClusterFuzz, Jan 12

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 2 by ClusterFuzz, Jan 12

Labels: Test-Predator-Auto-Owner
Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/angle/angle/+/c759b8b4388b1859b80ab7495074e8e9e7eef756 (Vulkan: More Vertex Array optimizations.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: -Pri-1 Pri-2
Benign bug, only affects the "null" back-end in ANGLE. Will fix it now.
Components: Internals>GPU>ANGLE
Blocking: angleproject:3014
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/9567b0c5720d6f5bc9fd58410f9208bcf6c879f6

commit 9567b0c5720d6f5bc9fd58410f9208bcf6c879f6
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jan 14 20:49:09 2019

Clear VAO dirty bits in NULL back-end.

This is the back-end responsibility now.

Bug:  chromium:921338 
Change-Id: I6181210a80ec7d635382df74d842d8a899ad2894
Reviewed-on: https://chromium-review.googlesource.com/c/1409405
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/9567b0c5720d6f5bc9fd58410f9208bcf6c879f6/src/libANGLE/renderer/null/VertexArrayNULL.h
[modify] https://crrev.com/9567b0c5720d6f5bc9fd58410f9208bcf6c879f6/src/libANGLE/renderer/null/VertexArrayNULL.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3632a7cb7b35fd2bf0ef32b4ec42a6a134d822bc

commit 3632a7cb7b35fd2bf0ef32b4ec42a6a134d822bc
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 15 01:23:27 2019

Roll src/third_party/angle 17a50e17004b..c2ee2ccbc79c (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/17a50e17004b..c2ee2ccbc79c


git log 17a50e17004b..c2ee2ccbc79c --date=short --no-merges --format='%ad %ae %s'
2019-01-14 timvp@google.com Vulkan: Don't support EGL_SWAP_BEHAVIOR_PRESERVED_BIT
2019-01-14 jmadill@chromium.org Clear VAO dirty bits in NULL back-end.


Created with:
  gclient setdep -r src/third_party/angle@c2ee2ccbc79c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:921338 
TBR=cwallez@chromium.org

Change-Id: Id4ccf5d58df294cee3512a126de0918fcafa5efb
Reviewed-on: https://chromium-review.googlesource.com/c/1409617
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#622665}
[modify] https://crrev.com/3632a7cb7b35fd2bf0ef32b4ec42a6a134d822bc/DEPS

Project Member

Comment 8 by ClusterFuzz, Jan 15

ClusterFuzz has detected this issue as fixed in range 622664:622666.

Detailed report: https://clusterfuzz.com/testcase?key=4906149782224896

Fuzzer: libFuzzer_gpu_angle_fuzzer
Fuzz target binary: gpu_angle_fuzzer
Job Type: x86_libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  mDirtyAttribBits[0].none()
  gl::VertexArray::syncState
  gl::State::syncVertexArray
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=x86_libfuzzer_chrome_asan_debug&range=622253:622274
Fixed: https://clusterfuzz.com/revisions?job=x86_libfuzzer_chrome_asan_debug&range=622664:622666

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4906149782224896

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Verified (was: Assigned)

Sign in to add a comment