New issue
Advanced search Search tips

Issue 921328 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 15
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 898475



Sign in to add a comment

Windows x64 jumbo build bot broken

Project Member Reported by r...@tambre.ee, Jan 12

Issue description

First failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Jumbo%20Win%20x64/25469

Cause:
The breakage is due to refactoring in https://chromium.googlesource.com/chromium/src/+/c0c56e43d06e4d6f75855ab992df726cf6011a93, which caused the file with the problematic Windows header to get included in the jumbo file in question.
Root cause seems to be a macro from Windows headers with the name MemoryBarrier, causing base::subtle::MemoryBarrier() to turn into base::subtle::__faststorefence().

Compile error:
[1967/3693] CXX obj/ppapi/proxy/proxy/proxy_jumbo_5.obj
FAILED: obj/ppapi/proxy/proxy/proxy_jumbo_5.obj 
C:\b\swarming\w\ir\cache\goma\client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\win_sdk\Include\10.0.17763.0\um -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\win_sdk\Include\10.0.17763.0\shared -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\win_sdk\Include\10.0.17763.0\winrt -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\win_sdk\Include\10.0.17763.0\ucrt -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\VC\Tools\MSVC\14.16.27023\include -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\VC\Tools\MSVC\14.16.27023\atlmfc\include -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD "-DCR_CLANG_REVISION=\"349417-2\"" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPPAPI_PROXY_IMPLEMENTATION -DENABLE_IPC_FUZZER -DWEBP_EXTERN=extern -DUSE_EGL -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DV8_DEPRECATION_WARNINGS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -I. -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../v8/include -Igen/v8/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/docs -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include /utf-8 /X -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -fcomplete-member-pointers /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m64 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-ignored-pragma-optimize /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-inconsistent-missing-override -Wno-shorten-64-to-32 /TP /wd4577 /GR- /c gen/ppapi/proxy/proxy_jumbo_5.cc /Foobj/ppapi/proxy/proxy/proxy_jumbo_5.obj /Fd"obj/ppapi/proxy/proxy_cc.pdb"
In file included from gen/ppapi/proxy/proxy_jumbo_5.cc:9:
In file included from .\../../ppapi/proxy/ppapi_command_buffer_proxy.cc:5:
In file included from ../..\ppapi/proxy/ppapi_command_buffer_proxy.h:18:
../..\gpu/command_buffer/common/command_buffer_shared.h(49,19):  error: no member named '__faststorefence' in namespace 'base::subtle'
    base::subtle::MemoryBarrier();
    ~~~~~~~~~~~~~~^
..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\win_sdk\Include\10.0.17763.0\um\winnt.h(3304,23):  note: expanded from macro 'MemoryBarrier'
#define MemoryBarrier __faststorefence
                      ^
In file included from gen/ppapi/proxy/proxy_jumbo_5.cc:9:
In file included from .\../../ppapi/proxy/ppapi_command_buffer_proxy.cc:5:
In file included from ../..\ppapi/proxy/ppapi_command_buffer_proxy.h:18:
../..\gpu/command_buffer/common/command_buffer_shared.h(52,19):  error: no member named '__faststorefence' in namespace 'base::subtle'
    base::subtle::MemoryBarrier();
    ~~~~~~~~~~~~~~^
..\..\third_party\depot_tools\win_toolchain\vs_files\818a152b3f1da991c1725d85be19a0f27af6bab4\win_sdk\Include\10.0.17763.0\um\winnt.h(3304,23):  note: expanded from macro 'MemoryBarrier'
#define MemoryBarrier __faststorefence
                      ^
2 errors generated.
 
Blocking: 898475

Sign in to add a comment