New issue
Advanced search Search tips

Issue 921323 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Build failure when compiling ulp_language_code_locator.cc on Windows in a jumbo build

Project Member Reported by r...@tambre.ee, Jan 12

Issue description

Chromium build options:
enable_nacl = false
is_component_build = true
use_jumbo_build = true
use_ghash = true
symbol_level = 0
remove_webcore_debug_symbols = true
use_lld = true

Error:
[26/36605] CXX obj/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator/ulp_language_code_locator.obj
FAILED: obj/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator/ulp_language_code_locator.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  "-imsvc..\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27027\ATLMFC\include" "-imsvc..\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.20.27027\include" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" "-imsvc..\..\..\..\..\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD "-DCR_CLANG_REVISION=\"350768-2\"" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_HAS_ITERATOR_DEBUGGING=0 -I../.. -Igen -I../../third_party/s2cellid/src /utf-8 /X -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 /Zc:dllexportInlines- -m64 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 /wd4702 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-ignored-pragma-optimize /Od /Ob0 /GF /MDd -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare /TP /wd4577 /GR- /c ../../components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.cc /Foobj/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator/ulp_language_code_locator.obj /Fd"obj/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_cc.pdb"
In file included from ../../components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.cc:5:
../..\components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.h(20,31):  error: no template named 'unique_ptr' in namespace 'std'
  UlpLanguageCodeLocator(std::unique_ptr<S2LangQuadTreeNode> root);
                         ~~~~~^
../..\components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.h(28,8):  error: no template named 'unique_ptr' in namespace 'std'
  std::unique_ptr<S2LangQuadTreeNode> root_;
  ~~~~~^
../../components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.cc(13,25):  error: out-of-line definition of 'UlpLanguageCodeLocator' does not match any declaration in 'language::UlpLanguageCodeLocator'
UlpLanguageCodeLocator::UlpLanguageCodeLocator(
                        ^~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
 
https://chromium.googlesource.com/chromium/src.git/+/6063cec9d2bfb3da334dd430a8a17c1236ffe85f is to blame.

Strangely Windows jumbo build bots don't seem to exhibit this failure.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e04685046540389e87b0ab78315a338ff48c31d1

commit e04685046540389e87b0ab78315a338ff48c31d1
Author: Raul Tambre <raul@tambre.ee>
Date: Tue Jan 15 08:03:29 2019

Fix missing include for std::unique_ptr in ulp_language_code_locator.h

This fixes jumbo builds on Windows.

Bug:  921323 
Change-Id: If77e2ed0e3e36add8ff4e81a15f792db76ea46ae
Reviewed-on: https://chromium-review.googlesource.com/c/1407207
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#622776}
[modify] https://crrev.com/e04685046540389e87b0ab78315a338ff48c31d1/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.h

Owner: r...@tambre.ee
Status: Fixed (was: Started)

Sign in to add a comment