Generated Wrapper Scripts should support installing "dependency APKs" (e.g., trichrome) |
||
Issue descriptionWith trichrome, we'll need to build & install both trichrome_webview_apk and trichrome_library_apk. I filed issue 921284 to track handling this dependency for building. I'm filing this ticket to handle the dependency when installing (via tooling). It'd be nice if "bin/trichrome_webview_apk install" would first install trichrome_library_apk, followed by trichrome_webview_apk. I believe our test runner scripts (e.g., bin/run_webview_instrumentation_test_apk) do something like this already--so maybe this is easy to solve :) For the case of trichrome, please note that installation order matters (library must be installed first). Ditto on all of the above, for "trichrome_chrome_apk".
,
Jan 14
,
Jan 14
Not sure I understand. To paraphrase, do you mean "installing TrichromeWebView and TrichromeLibrary, but not touching TrichromeChrome, is bad because everything breaks" or "... is bad because TrichromeChrome (the untouched package) is the only thing to break?" I think the former would be quite bad. I would argue the latter is acceptable; if you want Chrome to work correctly, you need to rebuild it too.
,
Jan 14
TrichromeChrome breaks, but it breaks even if nothing has been rebuilt at all and the APKs installed are exactly identical. Just reinstalling the exact same APK for the library appears to break *all* installed APKs that depend on it.
,
Jan 14
If we want to enforce all three are installed together, then we first need a build target to build all three. That seems rather disappointing reinstalls aren't idempotent... but I suppose that's the behavior we need to work with.
,
Jan 14
I filed b/111355172 about it a while ago. |
||
►
Sign in to add a comment |
||
Comment 1 by torne@chromium.org
, Jan 14