New issue
Advanced search Search tips

Issue 921284 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 887078



Sign in to add a comment

trichrome_webview_apk should "depend" on trichrome_library_apk in GN

Project Member Reported by ntfschr@chromium.org, Jan 12

Issue description

TrichromeWebView.apk and TrichromeChrome.apk both require TrichromeLibrary.apk to be installed (otherwise they fail). But, the current build system requires that I explicitly build both APKs.

It would be nicer to edit the build targets to use GN's "data_deps" [1] feature, so that we can express "building trichrome_webview_apk implies we must build trichrome_library_apk". Ditto for trichrome_chrome.

This won't affect installation (which, of course, is the more important part). But, the GN variable clearly expresses the dependency, and I don't think there's a reason *not* to use this.

Chrome for Android team regularly relies on the data_deps feature for tests. For example, webview_instrumentation_test_apk expresses a dependency on webview_instrumentation_apk with "apk_under_test" [2], which is implemented with data_deps [3].

[1] https://gn.googlesource.com/gn/+/master/docs/reference.md#var_data_deps
[2] https://cs.chromium.org/chromium/src/android_webview/test/BUILD.gn?l=148&rcl=09942f4374744a8849dc7cf9c8e4202ab65f47c6
[3] https://cs.chromium.org/chromium/src/build/config/android/rules.gni?l=3208&rcl=afdbd5c1990610566c6658b23e3aed3f9ade6acf
 
Blocking: 887078

Sign in to add a comment