New issue
Advanced search Search tips

Issue 921273 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Publish outgoing FIDL services to public directory

Project Member Reported by kmarshall@chromium.org, Jan 12

Issue description

Similar to here: 
https://fuchsia-review.googlesource.com/c/topaz/+/234337/15/runtime/web_runner_prototype/component_controller.cc#20 , ContextProvider/WebRunner should switch to publishing outgoing services as public services. ServiceDirectories have allowed for separating public from non-public/debug interfaces for a while, but appmgr had not been modified to use public services until very recently.

Fuchsia POC: anmittal@google.com
 
Description: Show this description
currently appmgr expects web_runner to publish component's service in root directory, but once web_runner publishes services in both public and root directory, we can change appmgr to expect public directory and after that we can clean web_runner to not publish services in root directory

Comment 3 by w...@chromium.org, Jan 17 (6 days ago)

Labels: -M-71 M-73
Owner: kmarshall@chromium.org
Status: Assigned (was: Untriaged)
kmarshall: Can you do the honours?

Comment 4 by kmarshall@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Assigned)
Apparently I time traveled to the past and made the change on Mon Jun 25 2018. ;)

https://chromium.googlesource.com/chromium/src/+/8b25a96808c1cde2f867d5d160287208d9088f00


Comment 5 by anmittal@google.com, Jan 17 (5 days ago)

so it was already in. awesome, how to test it once i fix garnet?

Sign in to add a comment