Issue metadata
Sign in to add a comment
|
crosperf: do not support run_local: true for telemetry_Crosperf |
||||||||||||||||||||||
Issue descriptionWe do not use run_local=true when running telemetry_Crosperf any more. And this mode also has a conflict with the future new mechanism in run_benchmark. So we want to remove this mode from the telemetry_Crosperf script.
,
Jan 12
,
Jan 14
,
Today
(81 minutes ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e51b458e6800eb30015a9eab9ddc9139eebe9a33 commit e51b458e6800eb30015a9eab9ddc9139eebe9a33 Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Jan 23 05:05:27 2019 crosperf: Do not allow profiling when run_local=true for telemetry_Crosperf This patch disables the mode when run_local set to true and profiler enabled. This is because we no longer use this mode to collect profiles and it has a conflict with future mechanism. TEST=tested with a simple octane test on link device, set run_local to both false and true and verified. BUG=chromium:921266 Change-Id: Iba0538c1c72ccb14a2909c65bf17c8393dd014ff Reviewed-on: https://chromium-review.googlesource.com/1407799 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/e51b458e6800eb30015a9eab9ddc9139eebe9a33/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py
,
Today
(60 minutes ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e51b458e6800eb30015a9eab9ddc9139eebe9a33 commit e51b458e6800eb30015a9eab9ddc9139eebe9a33 Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Jan 23 05:05:27 2019 crosperf: Do not allow profiling when run_local=true for telemetry_Crosperf This patch disables the mode when run_local set to true and profiler enabled. This is because we no longer use this mode to collect profiles and it has a conflict with future mechanism. TEST=tested with a simple octane test on link device, set run_local to both false and true and verified. BUG=chromium:921266 Change-Id: Iba0538c1c72ccb14a2909c65bf17c8393dd014ff Reviewed-on: https://chromium-review.googlesource.com/1407799 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/e51b458e6800eb30015a9eab9ddc9139eebe9a33/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py
,
Today
(38 minutes ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e51b458e6800eb30015a9eab9ddc9139eebe9a33 commit e51b458e6800eb30015a9eab9ddc9139eebe9a33 Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Jan 23 05:05:27 2019 crosperf: Do not allow profiling when run_local=true for telemetry_Crosperf This patch disables the mode when run_local set to true and profiler enabled. This is because we no longer use this mode to collect profiles and it has a conflict with future mechanism. TEST=tested with a simple octane test on link device, set run_local to both false and true and verified. BUG=chromium:921266 Change-Id: Iba0538c1c72ccb14a2909c65bf17c8393dd014ff Reviewed-on: https://chromium-review.googlesource.com/1407799 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/e51b458e6800eb30015a9eab9ddc9139eebe9a33/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by zhizhouy@chromium.org
, Jan 12