Issue metadata
Sign in to add a comment
|
29.3%-363.9% regression in blink_perf.owp_storage at 621319:621478 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 12
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/143df37d940000
,
Jan 12
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/143df37d940000 base: Improve base::File::Flush() on macOS and iOS. by pwnall@chromium.org https://chromium.googlesource.com/chromium/src/+/90c2ed99a4bd5d9fa949d9ba14b37c3c29b0d9fb blob-perf-files: 791.1 → 3377 (+2586) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/blink-perf-benchmarks
,
Jan 12
+cc other IndexedDB folks, for FYI We expected regressions, as described in the CL message, so marking this as WontFix. This pinpoint is a bit of a relief to me -- we now know that the change works, and that I/O is not so dominated by IPC overhead that it wouldn't matter at all. That being said, blink_perf.owp_storage is a bit of a micro-benchmark, so the number shouldn't be indicative of the real-life regression. We should use Forklift to see how we're doing.
,
Jan 15
As said in person, the worst regression here is a 360% regression on blob-perf-files, which while expected is very unfortunate as the blob system really doesn't need to be flushing as aggressive as this change made things do. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 12