New issue
Advanced search Search tips

Issue 921244 link

Starred by 1 user
Status: WontFix
Owner:
hajimehoshi@chromium.org
Closed: Jan 16
Cc:
grt@chromium.org
altimin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0% regression in sizes at 621968:621970

Project Member Reported by m...@chromium.org, Jan 12 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 12 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=921244

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f8fe2f27de05181cc1bcf4c82282eddd7c0c0401bce4e28f15ae4f6c03dad7cc


Bot(s) for this bug's original alert(s):

Google Chrome Win

Comment 2 by m...@chromium.org, Jan 15

Cc: -m...@chromium.org grt@chromium.org
Owner: hajimehoshi@chromium.org
Status: Assigned (was: Unconfirmed)
Likely culprit (due to adding an argument with tons of call points that has to create a scoped_refptr...is this valid Google C++ style?):

commit	daa895c08c58ef0cbef232ec0cf9efac4cf5b12e	
author	Hajime Hoshi <hajimehoshi@chromium.org>	Fri Jan 11 11:11:20 2019
committer	Commit Bot <commit-bot@chromium.org>	Fri Jan 11 11:11:20 2019

Add task_runner params to some of mojo bindings and use it.

Comment 3 by hajimehoshi@chromium.org, Jan 16

Cc: altimin@chromium.org
I think this is inevitable to add this argument, then I'd like to mark this wontfix.

+altimin, wdyt?

Comment 4 by hajimehoshi@chromium.org, Jan 16 (6 days ago)

Status: WontFix (was: Assigned)
►

Sign in to add a comment