New issue
Advanced search Search tips

Issue 921227 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Add presubmit/CQ bot to ensure PNGs checked in are optimized

Project Member Reported by tedc...@chromium.org, Jan 11

Issue description

It would be awesome if we could automatically warn CL authors that their image assets are not optimized.

I'm wondering if this could be something we add to the android binary size bot or maybe something else existing?  Wouldn't catch things for other platforms, but I don't know if there is a general purpose bot that could do this.

Basically any CL I see come by with assets I add a boiler plate comment:
"""
If we do need to add pngs, please make sure you run them through the compression script:
https://cs.chromium.org/chromium/src/chrome/app/theme/README?l=5
"""

The gotcha is that script is slow...really slow...so we wouldn't want to slow the CQ down but it would be good to automate this away if possible.

It would be nice to not have to do that.
 
Cc: huayinz@chromium.org
Labels: Type-Task
I think even a presubmit warning reminding folks to optimize would be great to start with, since right now I effectively do this with comments on CLs.
Labels: QuickFix
Status: Available (was: Untriaged)

Sign in to add a comment