New issue
Advanced search Search tips

Issue 921224 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 918537



Sign in to add a comment

SingleProcessMash: Window cycle view browser views are not showing up

Project Member Reported by sammiequon@chromium.org, Jan 11

Issue description

What steps will reproduce the problem?
(1) Open two browser windows.
(2) Alt_tab

What is the expected result?
See two smaller browser windows.

What happens instead?
Only see the titles.



 
Labels: Proj-Mash-SingleProcess
Related to SingleProcessMash? What version?

If not SingleProcessMash, please remove the label.

Yes, works with SIngleProcessMash, thanks for drive by check.

The version I was using is 73.0.3667.0. 
*works with SingleProcessMash disabled

Comment 4 by sky@chromium.org, Jan 16 (6 days ago)

Blocking: 918537

Comment 5 by jamescook@chromium.org, Jan 18 (4 days ago)

Owner: jamescook@chromium.org
Status: Started (was: Available)
Summary: SingleProcessMash: Window cycle view browser views are not showing up (was: Window cycle view browser views are not showing up.)
I can repro on ToT linux-chromeos at r624160
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2001dc07f1170286479774029c2bb725d09afddd

commit 2001dc07f1170286479774029c2bb725d09afddd
Author: James Cook <jamescook@chromium.org>
Date: Fri Jan 18 21:07:34 2019

Fix blank Alt-Tab window previews under SingleProcessMash

The mirror view size was zero because it wasn't correctly looking up
the widget.

Bug:  921224 
Test: added to ash_unittests
Change-Id: Ic7c09ffa92ecf345030758aa89ef7ec9aeb8d7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1422697
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624282}
[modify] https://crrev.com/2001dc07f1170286479774029c2bb725d09afddd/ash/BUILD.gn
[modify] https://crrev.com/2001dc07f1170286479774029c2bb725d09afddd/ash/wm/window_mirror_view.cc
[modify] https://crrev.com/2001dc07f1170286479774029c2bb725d09afddd/ash/wm/window_mirror_view.h
[add] https://crrev.com/2001dc07f1170286479774029c2bb725d09afddd/ash/wm/window_mirror_view_unittest.cc

Comment 7 by jamescook@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)

Sign in to add a comment