New issue
Advanced search Search tips

Issue 921212 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog

Blocking:
issue 912026



Sign in to add a comment

CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog is flaky

Project Member Reported by Findit, Jan 11

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237

commit 188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jan 11 23:22:13 2019

Revert "Extensions: Focus correct button on options dialog close."

This reverts commit 520af7b3824dd819dd134c926024234efd38e301.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 622110 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTIwYWY3YjM4MjRkZDgxOWRkMTM0YzkyNjAyNDIzNGVmZDM4ZTMwMQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/18532

Sample Failed Step: network_service_browser_tests on Intel GPU on Mac on Mac-10.12.6

Sample Flaky Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog

Original change's description:
> Extensions: Focus correct button on options dialog close.
> 
> Also fix some const references surfaced by presubmit.
> 
> Bug: 912026
> Change-Id: If18dc61d8284c86cbec9f23e09286e9c5f666824
> Reviewed-on: https://chromium-review.googlesource.com/c/1405459
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622110}

Change-Id: I28c92c8792556c3db05081a4aa2df3fe0eb91e91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912026, 921212
Reviewed-on: https://chromium-review.googlesource.com/c/1407786
Cr-Commit-Position: refs/heads/master@{#622210}
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/test/data/extensions/options_page_in_view/manifest.json
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/test/data/webui/extensions/manager_test.js

Blocking: 912026
Labels: -Sheriff-Chromium
Status: Assigned (was: Untriaged)
Yep, my CL added the test. Will investigate to make sure this is fixed before re-landing.

Removing from sheriff queue since CL was reverted.

Sign in to add a comment