SingleProcessMash: dvorak keyboard layout is entirely broken on nocturne |
|||||||
Issue descriptionI just installed a 11558.0.0 test image on my nocturne and the dvorak keyboard layout is entirely broken. I'm not even sure what layout it thinks it is. QWERTY seems fine though. here's the homerow: ar.gcedybo it's completely wrong, it should be aoeuidhtns- Here's a feedback report I filed: http://shortn/_wfCiWHFnE8
,
Jan 11
Re #1: shuchen@, yhanada@ or kpschoedel@ should know.
,
Jan 12
Drive-by: That version has the new sysui SingleProcessMash feature enabled. Could you try turning it off in about:flags? If the problem goes away, please assign the bug to me and I'll route it. Otherwise, the people in #2 seem right.
,
Jan 12
Hey James, yes, disabling that flag restored the correct dvorak layout.
,
Jan 12
xiyuan/msw/stevenjb - IME issue? Event rewriter issue?
,
Jan 12
aaboagye: I just reverted SingleProcessMash on Chrome ToT, so the next uprev should fix this problem for you.
,
Jan 12
Thanks so much!
,
Jan 14
,
Jan 14
,
Jan 16
I explained the weirdness in issue 919271 . It's like the keys are being translated *twice* instead of just once: "asdf" => "aoeu" => "ar.g" QWERTY "asdf" == Dvorak "aoeu" QWERTY "aoeu" == Dvorak "ar.g"
,
Jan 16
You are exactly right that the map is applied twice.
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1 commit 154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1 Author: Scott Violet <sky@chromium.org> Date: Fri Jan 18 20:47:52 2019 Modernize Mojo serialization of ui::KeyEvents This changes serialization to write key_code, dom_code, dom_key and whether it's a character. These four things are the key properties that identify a KeyEvent. The previous code would result in potentially applying keyboard layouts to the deserialized event, which is problematic if the layout was already applied before serialization. BUG= 921202 TEST=covered by tests Change-Id: I7a15ed2fce6e084988b8f23bbf2f06f420ff3771 Reviewed-on: https://chromium-review.googlesource.com/c/1409461 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#624269} [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/chrome/browser/chromeos/preferences.h [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/event.cc [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/event.h [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/event_constants.h [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/keycodes/dom/dom_key.h [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/mojo/event.mojom [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/mojo/struct_traits_unittest.cc [modify] https://crrev.com/154ad7d65aa5ad38dd1ce19ee1c4cc9cb799c9a1/ui/events/ozone/layout/keyboard_layout_engine_manager.cc
,
Jan 18
(4 days ago)
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aaboagye@chromium.org
, Jan 11