New issue
Advanced search Search tips

Issue 921197 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Simplify XR instrumentation test server usage

Project Member Reported by bsheedy@chromium.org, Jan 11 
Currently, anytime an XR instrumentation test loads a URL served by the embedded test server, the test has to get a string from the framework pointing to the file, pass that to the server to get a URL, and load that. This is leftover from when the test server was not tied to the activity being tested (and thus the framework couldn't access it), so the best it could do was return a string to pass to the server.

This should be able to be updated now so that there is no difference between loading from a file:// URL or a URL for the local server other than calling the method to get the URL for the correct type.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7

commit 0fecc7c6847dea6825a74a9d8e426121ae7fb0c7
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Jan 14 20:06:39 2019

Simplify XR instrumentation test server usage

Simplifies usage of the EmbeddedTestServer in XR instrumentation tests
by moving the URL generation into XrTestFramework instead of simply
providing a string that the test needs to pass to
EmbeddedTestServer.getUrl().

Bug:  921197 
Change-Id: Id76e280a73e936a57e3924dd8552616fa4391654
Reviewed-on: https://chromium-review.googlesource.com/c/1407952
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622563}
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserDialogTest.java
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserNativeUiTest.java
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserTransitionTest.java
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrInputTest.java
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrTabTest.java
[modify] https://crrev.com/0fecc7c6847dea6825a74a9d8e426121ae7fb0c7/chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java

Comment 2 by bsheedy@chromium.org, Today (7 hours ago)

Status: Fixed (was: Started)
►

Sign in to add a comment