New issue
Advanced search Search tips

Issue 921191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----


Participants' hotlists:
Launcher-A11y
Launcher-Broken


Sign in to add a comment

Chrome vox a11y focus indicator (golden boxes) are off in the folder

Project Member Reported by newcomer@chromium.org, Jan 11

Issue description

Chrome Version: 73.0.3668.0

What steps will reproduce the problem?
(1) Enable chrome vox
(2) Open a folder in the launcher
(3) Move focus around to the elements of the folder.

What is the expected result?
Golden focus boxes follow the views perfectly (like elsewhere in the launcher).

What happens instead?
Focus boxes are off by a fixed amount.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Can you try with SingleProcessMash disabled?

Comment 2 by weidongg@chromium.org, Today (11 hours ago)

Owner: weidongg@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid, Today (9 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211b2150ec4cdceedcc59facdb3210778582a277

commit 211b2150ec4cdceedcc59facdb3210778582a277
Author: Weidong Guo <weidongg@chromium.org>
Date: Tue Jan 22 21:29:57 2019

Fix vox focus indicator in app list folder

Changes:
|contents_view_| in AppListFolderView applies transform. When the
transform is updated, the locations of view nodes are not updated
automatically. So manually notify the updates.

Bug:  921191 
Change-Id: I474fc7a0fb9a81403b0cee36e5583716d33d6cdf
Reviewed-on: https://chromium-review.googlesource.com/c/1427441
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624926}
[modify] https://crrev.com/211b2150ec4cdceedcc59facdb3210778582a277/ash/app_list/views/app_list_folder_view.cc
[modify] https://crrev.com/211b2150ec4cdceedcc59facdb3210778582a277/ash/app_list/views/app_list_folder_view.h

Comment 4 by weidongg@chromium.org, Today (9 hours ago)

Status: Fixed (was: Started)

Sign in to add a comment