Normalized apk size metric should discount ELF alignment padding |
|||||
Issue descriptionIt's annoying that it jumps by 4096 chunks, and even more-so that it reports 0 bytes for changes that don't cross the threshold. Rather than looking at the .so size, we should SUM the elf section sizes in resource_sizes.py. Should also update the metric explanation here: https://cs.chromium.org/chromium/src/docs/speed/binary_size/metrics.md
,
Jan 14
,
Jan 21
(2 days ago)
,
Yesterday
(38 hours ago)
,
Yesterday
(33 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/616b8605e696f3268055256d3c1838398e87a052 commit 616b8605e696f3268055256d3c1838398e87a052 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Jan 21 21:05:47 2019 Android: Do not include ELF padding in normalized_apk_size metric This should make android-binary-size more clear about the size impact of commits. Previously all small native code changes would have a normalized size delta of 0 or 4kb. Bug: 921160 Change-Id: Ifa98681fc9f92d9e238140782153513927ae2f97 Reviewed-on: https://chromium-review.googlesource.com/c/1423663 Commit-Queue: agrieve <agrieve@chromium.org> Auto-Submit: agrieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#624669} [modify] https://crrev.com/616b8605e696f3268055256d3c1838398e87a052/build/android/resource_sizes.py [modify] https://crrev.com/616b8605e696f3268055256d3c1838398e87a052/docs/speed/binary_size/metrics.md [modify] https://crrev.com/616b8605e696f3268055256d3c1838398e87a052/tools/binary_size/BUILD.gn
,
Yesterday
(29 hours ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by agrieve@chromium.org
, Jan 14