[SingleProcessMash] Can't drag PIP window. |
||||||
Issue descriptionToT(commit position 622104) I can drag the window using frame, but can't resize the window. No resize shadow when mouse hovers at the edge. Window dragging (in addition to resizing) is broken for PIP window, probably for the same reason.
,
Jan 11
device: PixelSlate.
,
Jan 11
what's the easiest way to get a pip window?
,
Jan 11
I wonder if Mukai's patch @ https://chromium-review.googlesource.com/c/chromium/src/+/1405458 fixes this.
,
Jan 11
mukai's patch landed at 622061, oshima is at 622104. Possibly related to fractional scale factor?
,
Jan 11
To test PIP 1) play youtube video 2) On video element, click right button twice. I'll open the native menu (not custom one created by youtube) 3) Select "picture-in-picture"
,
Jan 11
,
Jan 11
It was working a couple of days ago. It may be easier to just run bisect.
,
Jan 11
> It was working a couple of days ago. It may be easier to just run bisect. presumably because we just enabled single process mash by default.
,
Jan 11
It was with SPM (at least the label was there)
,
Jan 11
At least it's not draggable/resizable at r620241 in Monday.
,
Jan 11
Note: my patch r622061 was reverted for an unrelated reason, but the resize shadow might appear with that revert. Still can't resize/drag.
,
Jan 12
The thing is: - Several window properties are not properly transferred, so ash can't say about the resizing - the dragging behavior is implemented here: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/overlay/overlay_window_views.cc?q=chrome/browser/ui/views/overlay/overlay_window_views.cc&sq=package:chromium&g=0&l=103 It seems the picture-in-picture hasn't been well recognized by us and so has been broken in Mash actually. The point in #c10 would indicate the regression caused by my patch.
,
Jan 12
It seems resizing hasn't been working well because some features are not supported in Mash. Filed issue 921272 for that.
,
Jan 14
editing the title since the window resizing was fixed. I'll take care of PIP windows.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/521aea0cbc7fcc5921d3ffe56c27b8232acdcdc6 commit 521aea0cbc7fcc5921d3ffe56c27b8232acdcdc6 Author: Jun Mukai <mukai@chromium.org> Date: Mon Jan 14 21:29:58 2019 Allow PipWindowKey for SingleProcessMash This window property is used to indicate a window is picture-in- picture mode; without this property, incorrect window resizer will be used. Bug: 921156 Test: manually Change-Id: I31e8f11378ee2ab862f4c3217f5ad94acd1dc9dc Reviewed-on: https://chromium-review.googlesource.com/c/1409690 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#622609} [modify] https://crrev.com/521aea0cbc7fcc5921d3ffe56c27b8232acdcdc6/ash/public/cpp/mus_property_mirror_ash.cc [modify] https://crrev.com/521aea0cbc7fcc5921d3ffe56c27b8232acdcdc6/ash/public/cpp/window_properties.cc [modify] https://crrev.com/521aea0cbc7fcc5921d3ffe56c27b8232acdcdc6/ash/public/interfaces/window_properties.mojom |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by osh...@chromium.org
, Jan 11