New issue
Advanced search Search tips

Issue 921140 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

web_dev_style: ESLint tests fail when run from external directory

Project Member Reported by dbeam@chromium.org, Jan 11 
works:

  $ cd $SRC/tools/web_dev_style
  $ ./js_checker_eslint_test.py

doesn't work:

  $ cd $SRC
  $ tools/web_dev_style/js_checker_eslint_test.py

we should fix js_checker_eslint_test.py to be directory-agnostic.

Comment 1 by dpa...@chromium.org, Jan 11

Components: UI>Browser>WebUI

Comment 2 by dpa...@chromium.org, Jan 11 

Pasting error output as well

======================================================================
FAIL: testGetElementByIdCheck (__main__.JsCheckerEsLintTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tools/web_dev_style/js_checker_eslint_test.py", line 48, in testGetElementByIdCheck
    self._assertError(results_json, 'no-restricted-properties', 1)
  File "tools/web_dev_style/js_checker_eslint_test.py", line 40, in _assertError
    self.assertEqual(1, len(results))
AssertionError: 1 != 0

======================================================================
FAIL: testPrimitiveWrappersCheck (__main__.JsCheckerEsLintTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tools/web_dev_style/js_checker_eslint_test.py", line 52, in testPrimitiveWrappersCheck
    self._assertError(results_json, 'no-new-wrappers', 1)
  File "tools/web_dev_style/js_checker_eslint_test.py", line 40, in _assertError
    self.assertEqual(1, len(results))
AssertionError: 1 != 0
►

Sign in to add a comment