Filing this to keep track of https://chromium-review.googlesource.com/c/chromium/src/+/1389167/2/chrome/browser/ui/omnibox/lookalike_url_service.cc#69
Dom's comments:
"""
This probably warrants putting engagement level on the details object for efficiency and better code (otherwise this is going to query content settings again to calculate engagement then the level). If you don't mind doing it in this CL, it's a fairly small addition:
a) changing SiteEngagementService::IsEngagementAtLeast to simply call:
auto level = CreateEngagementScore(url).GetEngagementLevel();
// then do the comparison
b) adding a GetEngagementLevel() call to SiteEngagementScore::GetDetails.
c) adding the field in chrome/browser/engagement/site_engagement_details.mojom
"""
Comment 1 by livvielin@chromium.org
, Jan 18 (4 days ago)Status: Assigned (was: Untriaged)