Regression: Audio player output is not smooth |
||||||||
Issue descriptionhttps://buganizer.corp.google.com/issues/122329052 identified the issue. The regression was introduced here https://chromium-review.googlesource.com/c/chromium/src/+/1325012. The time updates from the audio player is feeding back to updating the audio player time. Sometimes this can cause the time to jump back a very small amount. There is no reason to have this update that originated from the audio player to feedback to the audio player.
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56d631bd58a2ce565e6d700055b5dcb9d817be35 commit 56d631bd58a2ce565e6d700055b5dcb9d817be35 Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jan 11 22:17:24 2019 Audio Player WebUI: remove time update feedback Bug: 921118 Change-Id: I3d75a4542d86168c9c920681fc889478872774f6 Reviewed-on: https://chromium-review.googlesource.com/c/1407496 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#622184} [modify] https://crrev.com/56d631bd58a2ce565e6d700055b5dcb9d817be35/ui/file_manager/audio_player/elements/audio_player.html [modify] https://crrev.com/56d631bd58a2ce565e6d700055b5dcb9d817be35/ui/file_manager/audio_player/elements/audio_player.js [modify] https://crrev.com/56d631bd58a2ce565e6d700055b5dcb9d817be35/ui/file_manager/audio_player/elements/control_panel.js
,
Jan 11
,
Jan 12
,
Jan 12
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e6714bc23b3eed6438ab5b03bc5ee3365386bb4 commit 3e6714bc23b3eed6438ab5b03bc5ee3365386bb4 Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Jan 14 20:22:47 2019 Merge to release branch M72 Audio Player WebUI: remove time update feedback (cherry picked from commit 56d631bd58a2ce565e6d700055b5dcb9d817be35) Bug: 921118 Change-Id: I3d75a4542d86168c9c920681fc889478872774f6 Reviewed-on: https://chromium-review.googlesource.com/c/1407496 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622184} Reviewed-on: https://chromium-review.googlesource.com/c/1409964 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#674} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/3e6714bc23b3eed6438ab5b03bc5ee3365386bb4/ui/file_manager/audio_player/elements/audio_player.html [modify] https://crrev.com/3e6714bc23b3eed6438ab5b03bc5ee3365386bb4/ui/file_manager/audio_player/elements/audio_player.js [modify] https://crrev.com/3e6714bc23b3eed6438ab5b03bc5ee3365386bb4/ui/file_manager/audio_player/elements/control_panel.js
,
Jan 14
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 3e6714bc23b3eed6438ab5b03bc5ee3365386bb4 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e6714bc23b3eed6438ab5b03bc5ee3365386bb4 Commit: 3e6714bc23b3eed6438ab5b03bc5ee3365386bb4 Author: aee@chromium.org Commiter: aee@chromium.org Date: 2019-01-14 20:22:47 +0000 UTC Merge to release branch M72 Audio Player WebUI: remove time update feedback (cherry picked from commit 56d631bd58a2ce565e6d700055b5dcb9d817be35) Bug: 921118 Change-Id: I3d75a4542d86168c9c920681fc889478872774f6 Reviewed-on: https://chromium-review.googlesource.com/c/1407496 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622184} Reviewed-on: https://chromium-review.googlesource.com/c/1409964 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#674} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 18
(4 days ago)
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by aee@chromium.org
, Jan 11