Navi A11y - Buttons do not report checked status |
||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Launch chrome with Navi enabled 2. Use NVDA to navigate to the email or google apps selection modules What is the expected result? Buttons should report their checked status What happens instead of that? Notice that buttons that are checked are treated the same way by the screen reader.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef85ed087563d2a99f3a817f5bc980a4706eed01 commit ef85ed087563d2a99f3a817f5bc980a4706eed01 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Jan 15 01:43:18 2019 Navi A11y - Add aria-pressed attribute to app chooser buttons. Bug: 921117 Change-Id: I1846caf894b72ca3e8a125fc94b438dc57f85acd Reviewed-on: https://chromium-review.googlesource.com/c/1407954 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#622669} [modify] https://crrev.com/ef85ed087563d2a99f3a817f5bc980a4706eed01/chrome/browser/resources/welcome/onboarding_welcome/shared/app_chooser.html [modify] https://crrev.com/ef85ed087563d2a99f3a817f5bc980a4706eed01/chrome/browser/resources/welcome/onboarding_welcome/shared/app_chooser.js
,
Jan 15
Verified that this is working as expected on Canary. This fixes an a11y issue for project navi. Entire change is contained behind a flag for project navi. Change is only HTML + JavaScript
,
Jan 15
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 15
branch:3626
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5ea22878c9371abef7ffba59342f6f980f39fa3 commit a5ea22878c9371abef7ffba59342f6f980f39fa3 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Jan 15 22:57:16 2019 Navi A11y - Add aria-pressed attribute to app chooser buttons. (cherry picked from commit ef85ed087563d2a99f3a817f5bc980a4706eed01) Bug: 921117 Change-Id: I1846caf894b72ca3e8a125fc94b438dc57f85acd Reviewed-on: https://chromium-review.googlesource.com/c/1407954 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622669} Reviewed-on: https://chromium-review.googlesource.com/c/1413394 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#704} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/a5ea22878c9371abef7ffba59342f6f980f39fa3/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/a5ea22878c9371abef7ffba59342f6f980f39fa3/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/a5ea22878c9371abef7ffba59342f6f980f39fa3/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [modify] https://crrev.com/a5ea22878c9371abef7ffba59342f6f980f39fa3/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
,
Jan 15
Merged, should be fixed in next beta build
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5ea22878c9371abef7ffba59342f6f980f39fa3 Commit: a5ea22878c9371abef7ffba59342f6f980f39fa3 Author: hcarmona@chromium.org Commiter: hcarmona@chromium.org Date: 2019-01-15 22:57:16 +0000 UTC Navi A11y - Add aria-pressed attribute to app chooser buttons. (cherry picked from commit ef85ed087563d2a99f3a817f5bc980a4706eed01) Bug: 921117 Change-Id: I1846caf894b72ca3e8a125fc94b438dc57f85acd Reviewed-on: https://chromium-review.googlesource.com/c/1407954 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622669} Reviewed-on: https://chromium-review.googlesource.com/c/1413394 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#704} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 16
(6 days ago)
Verified the fix on Windows-10 using Chrome version #72.0.3626.64 as per the comment #0. Attaching screen cast for reference. Observed NVDA has read the buttons. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version without fix. Thanks...!! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hcarmona@chromium.org
, Jan 14