Regression: Discover APP is not positioned at the center with --enable-features=SingleProcessMash |
||||
Issue descriptionRun "Linux Chrome OS build" with --enable-features=DiscoverApp, start Discover App from the list of apps, and observe it aligned on the top left corner. When --disable-features=SingleProcessMash switch is added, it gets back to the center. Basically https://chromium-review.googlesource.com/c/1278802 no longer works.
,
Jan 11
,
Jan 11
estade, could you take a look at this? See the above CL - maybe it should operate on the browser's Widget? Or it's using the wrong aura window for SingleProcessMash?
,
Jan 11
sure, will look into it.
,
Jan 11
Has 'Discover App' launched? Is it targetting 73?
,
Jan 11
Not yet. It's not targeted M73. сб, 12 янв. 2019 г., 2:16 sky via monorail monorail+v2.3231893262@chromium.org:
,
Jan 12
fix is simple and in CQ.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86a613b361ac74ca43cdd42f8961536cb757540a commit 86a613b361ac74ca43cdd42f8961536cb757540a Author: Evan Stade <estade@chromium.org> Date: Mon Jan 14 18:09:50 2019 Fix initial position of discovery app in single process mash. Instead of setting bounds on the aura::Window, set it on the Widget (by way of browser's BrowserWindow) Bug: 921114 Change-Id: I5aa853d3d990d87ece4a7b352c11509b7c543bea Reviewed-on: https://chromium-review.googlesource.com/c/1407632 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#622512} [modify] https://crrev.com/86a613b361ac74ca43cdd42f8961536cb757540a/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.cc
,
Jan 14
|
||||
►
Sign in to add a comment |
||||
Comment 1 by alemate@chromium.org
, Jan 11