New issue
Advanced search Search tips

Issue 921103 link

Starred by 1 user
Status: Started
Owner:
bsheedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Port VR UI test interaction functionality from Android to Windows

Project Member Reported by bsheedy@chromium.org, Jan 11 
There are a number of useful pieces of test code that allow the Android VR instrumentation tests to interact with the native UI, such as reliably clicking on elements or waiting for elements to reach a particular visibility state.

This functionality is not currently available in the Windows browser test version of the XR test framework, but should be relatively easy to port since the same underlying code is used for handling UI in production.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03a10a29c82cbd1f69317ce5490a2e39d478b840

commit 03a10a29c82cbd1f69317ce5490a2e39d478b840
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jan 15 01:52:12 2019

Port VR UI visibility status code to Windows

Ports the portion of the native VR UI interaction test code that allows
waiting on a UI element to reach a desired visibility state to the
XR browser test framework.

Also adds a test using this that ensures a notification is displayed
in the headset when a permission prompt is displayed in the browser.

Also fixes several issues in production code that were caught by the
test:
1. Added a name to the notification UI element.
2. Added early returns when interacting with the notification/overlay
   if the mojo interface is not bound, which could happen if Chrome
   was closed while still in VR with a notification displayed.

Bug: 921103
Change-Id: Ib157ce2014132a41233f3aefde5f9521d56cf168
Reviewed-on: https://chromium-review.googlesource.com/c/1407663
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622674}
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/browser_renderer.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/browser_renderer.h
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/elements/ui_element_name.h
[add] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/test/browser_test_browser_renderer_browser_interface.cc
[add] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/test/browser_test_browser_renderer_browser_interface.h
[add] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/test/ui_utils.cc
[add] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/test/ui_utils.h
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/test/xr_browser_test.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/test/xr_browser_test.h
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/ui.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/ui_test_input.h
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/webxr_vr_input_browser_test.cc
[add] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/webxr_vr_permission_request_browser_test.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/webxr_vr_pixel_browser_test.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/webxr_vr_tab_browser_test.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/webxr_vr_transition_browser_test.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/win/vr_browser_renderer_thread_win.cc
[modify] https://crrev.com/03a10a29c82cbd1f69317ce5490a2e39d478b840/chrome/browser/vr/win/vr_browser_renderer_thread_win.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee8373ae9828abad9ed511dff1fddaac7479955

commit 8ee8373ae9828abad9ed511dff1fddaac7479955
Author: Brian Sheedy <bsheedy@chromium.org>
Date: Tue Jan 15 19:21:44 2019

Revert "Port VR UI visibility status code to Windows"

This reverts commit 03a10a29c82cbd1f69317ce5490a2e39d478b840.

Reason for revert:  https://crbug.com/921739  is getting hit very frequently on one bot.

Original change's description:
> Port VR UI visibility status code to Windows
> 
> Ports the portion of the native VR UI interaction test code that allows
> waiting on a UI element to reach a desired visibility state to the
> XR browser test framework.
> 
> Also adds a test using this that ensures a notification is displayed
> in the headset when a permission prompt is displayed in the browser.
> 
> Also fixes several issues in production code that were caught by the
> test:
> 1. Added a name to the notification UI element.
> 2. Added early returns when interacting with the notification/overlay
>    if the mojo interface is not bound, which could happen if Chrome
>    was closed while still in VR with a notification displayed.
> 
> Bug: 921103
> Change-Id: Ib157ce2014132a41233f3aefde5f9521d56cf168
> Reviewed-on: https://chromium-review.googlesource.com/c/1407663
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622674}

TBR=bsheedy@chromium.org,billorr@chromium.org

Change-Id: I200b51906c0807fc909dbed9f340798cd6248129
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 921103
Reviewed-on: https://chromium-review.googlesource.com/c/1413059
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622872}
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/browser_renderer.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/browser_renderer.h
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/elements/ui_element_name.h
[delete] https://crrev.com/029dc5666f102091950f645ef9023be7b32d4ba3/chrome/browser/vr/test/browser_test_browser_renderer_browser_interface.cc
[delete] https://crrev.com/029dc5666f102091950f645ef9023be7b32d4ba3/chrome/browser/vr/test/browser_test_browser_renderer_browser_interface.h
[delete] https://crrev.com/029dc5666f102091950f645ef9023be7b32d4ba3/chrome/browser/vr/test/ui_utils.cc
[delete] https://crrev.com/029dc5666f102091950f645ef9023be7b32d4ba3/chrome/browser/vr/test/ui_utils.h
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/test/xr_browser_test.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/test/xr_browser_test.h
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/ui.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/ui_test_input.h
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/webxr_vr_input_browser_test.cc
[delete] https://crrev.com/029dc5666f102091950f645ef9023be7b32d4ba3/chrome/browser/vr/webxr_vr_permission_request_browser_test.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/webxr_vr_pixel_browser_test.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/webxr_vr_tab_browser_test.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/webxr_vr_transition_browser_test.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/win/vr_browser_renderer_thread_win.cc
[modify] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/browser/vr/win/vr_browser_renderer_thread_win.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb0f357e019705d8317798bb70476363ce3d2cc

commit acb0f357e019705d8317798bb70476363ce3d2cc
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jan 16 23:30:14 2019

Reland "Port VR UI visibility status code to Windows"

This is a reland of 03a10a29c82cbd1f69317ce5490a2e39d478b840

Original change's description:
> Port VR UI visibility status code to Windows
> 
> Ports the portion of the native VR UI interaction test code that allows
> waiting on a UI element to reach a desired visibility state to the
> XR browser test framework.
> 
> Also adds a test using this that ensures a notification is displayed
> in the headset when a permission prompt is displayed in the browser.
> 
> Also fixes several issues in production code that were caught by the
> test:
> 1. Added a name to the notification UI element.
> 2. Added early returns when interacting with the notification/overlay
>    if the mojo interface is not bound, which could happen if Chrome
>    was closed while still in VR with a notification displayed.
> 
> Bug: 921103
> Change-Id: Ib157ce2014132a41233f3aefde5f9521d56cf168
> Reviewed-on: https://chromium-review.googlesource.com/c/1407663
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622674}

Bug: 921103
Change-Id: Ifb9ef3b23a6340ce52b4038715daaf578e91ac52
Reviewed-on: https://chromium-review.googlesource.com/c/1415710
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623447}
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/browser_renderer.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/browser_renderer.h
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/elements/ui_element_name.h
[add] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/test/browser_test_browser_renderer_browser_interface.cc
[add] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/test/browser_test_browser_renderer_browser_interface.h
[add] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/test/ui_utils.cc
[add] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/test/ui_utils.h
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/test/xr_browser_test.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/test/xr_browser_test.h
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/ui.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/ui_test_input.h
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/webxr_vr_input_browser_test.cc
[add] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/webxr_vr_permission_request_browser_test.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/webxr_vr_pixel_browser_test.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/webxr_vr_tab_browser_test.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/webxr_vr_transition_browser_test.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/win/vr_browser_renderer_thread_win.cc
[modify] https://crrev.com/acb0f357e019705d8317798bb70476363ce3d2cc/chrome/browser/vr/win/vr_browser_renderer_thread_win.h
►

Sign in to add a comment