This issue has been marked as started, but has no owner. Making available.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9beb97e8bd9f725e5348f6af196e26f62fc4d292

commit 9beb97e8bd9f725e5348f6af196e26f62fc4d292
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Jan 11 22:00:19 2019

[Media Router] Don't show cloud sinks for incognito windows.

The Cloud MRP does not support casting to cloud sinks from incognito. This patch
filters them from the Cast dialog.

Other fixes:
 - Use base::EraseIf consistently
 - Replace Equals() with == in MediaSinkWithCastModes
 - Misc IWYU

Internal bug: b/37546693

Bug:  921094 
Change-Id: I1ba7bf52e37f67ed4f6b6df3579ae109932db615
Reviewed-on: https://chromium-review.googlesource.com/c/1406309
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622174}
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/media_router/media_router_ui_base.cc
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/media_router/media_sink_with_cast_modes.cc
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/media_router/media_sink_with_cast_modes.h
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/views/media_router/media_router_views_ui.h
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/browser/ui/views/media_router/media_router_views_ui_unittest.cc
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/common/media_router/media_sink.cc
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/common/media_router/media_sink.h
[modify] https://crrev.com/9beb97e8bd9f725e5348f6af196e26f62fc4d292/chrome/common/media_router/media_sink_unittest.cc

Is the effect of this change visible by websites? (Can't be used by a website to find out it's in incognito mode?)

No, we still show cloud sinks as available to the Presentation API in incognito.

If all the cloud sinks are unavailable in the dialog, the user will cancel the presentation request.  But they the user could cancel it anyway even if there are sinks available.

Thank you.