New issue
Advanced search Search tips

Issue 921091 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Previews.PageEndReason.Offline UMA has no entries

Project Member Reported by sophiechang@chromium.org, Jan 11

Issue description

Looks like an oversight that it was not recorded in offline_page_previews_page_load_metrics_observer
 
Cc: ryansturm@chromium.org
Apparently this is somewhat working as intended. So just marking as won't fix.
Status: WontFix (was: Assigned)
Status: Started (was: WontFix)
actually going to do this
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea5bd633c61ae2f52e9774fed043e76c9ff23d4a

commit ea5bd633c61ae2f52e9774fed043e76c9ff23d4a
Author: Sophie Chang <sophiechang@chromium.org>
Date: Thu Jan 17 00:46:30 2019

Start recording Previews.PageEndReason.Offline

The path is slightly different than other previews and does not call in the previews_ukm_observer for some reason.

Bug:  921091 
Change-Id: I31e55485c88919563bbe2d842ee4a6b25026bbe3
Reviewed-on: https://chromium-review.googlesource.com/c/1414190
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623466}
[modify] https://crrev.com/ea5bd633c61ae2f52e9774fed043e76c9ff23d4a/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer.cc
[modify] https://crrev.com/ea5bd633c61ae2f52e9774fed043e76c9ff23d4a/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer.h
[modify] https://crrev.com/ea5bd633c61ae2f52e9774fed043e76c9ff23d4a/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer_unittest.cc

Comment 5 by sophiechang@chromium.org, Jan 17 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment