New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 921065 link

Starred by 1 user
Status: Started
Owner:
arthurso...@chromium.org
Cc:
clamy@chromium.org
dtrainor@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[Task] NavigationHandle.java

Project Member Reported by arthurso...@chromium.org, Jan 11 
With the Java API:
WebContentsObserver.did(Start|Redirect|Finish)Navigation(...)
instead of forwarding many attributes, wrap them into a new class NavigationHandle.java

pros:
 - Each time a new argument is added, there is no need to update all
   the listeners.
 - Java with the NavigationHandle.java is now using the same interface
   as the NavigationHandle.cpp.
 - JNI can be used to directly map C++ attributes/methods if needed.

Comment 1 by arthurso...@chromium.org, Jan 11

Components: UI>Browser>Navigation

Comment 2 by nasko@chromium.org, Jan 11

Cc: nasko@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e97d731715229ace1a709f21f1ad432cbac463f

commit 2e97d731715229ace1a709f21f1ad432cbac463f
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Wed Jan 16 08:54:15 2019

Remove |isErrorPage| from WebContentsObserver.didStartNavigation().

Two reasons:
 - This argument is constant. Equal to false in didStartNavigation()
 - This argument is unused.

Bug: 921065
Change-Id: I2a89d5818e25b8fb627036dc2235622efbf9165e
Reviewed-on: https://chromium-review.googlesource.com/c/1409302
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623160}
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarAppearanceTest.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/content/browser/android/web_contents_observer_proxy.cc
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
[modify] https://crrev.com/2e97d731715229ace1a709f21f1ad432cbac463f/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
►

Sign in to add a comment