New issue
Advanced search Search tips

Issue 921041 link

Starred by 2 users
Status: Available
Owner:
orphis@chromium.org
Cc:
hbos@chromium.org
orphis@chromium.org
amithi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webrtc-simulcast.html is outdated and only works in Plan B

Project Member Reported by hbos@chromium.org, Jan 11 
The browser_tests WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams executes webrtc-simulcast.html which has Plan B assumptions:
https://cs.chromium.org/chromium/src/chrome/test/data/webrtc/webrtc-simulcast.html?q=webrtc/webrtc-simulcast.html&sq=package:chromium&dr

Clean this up, preferably by replacing it altogether with layout tests that can run both Plan B and Unified Plan.

Comment 1 by hbos@chromium.org, Jan 11 

orphis@ you tested simulcast locally by munging SDP, would it be possible to turn some of that code into layout tests?

I'm trying to make RTCUnifiedPlanByDefault a FEATURE_ENABLED_BY_DEFAULT and this ancient browser_tests started failing. It's full of hardcoded SDP and doing weird things like setLocalDescription before creating transceivers... so I don't really feel like debugging why it's not working when we would probably want all of this to be tested as layout tests instead.

Comment 2 by philipp....@googlemail.com, Jan 11 

have you considered buying time by setting plan-b as sdpSemantics in the remote pc?

Comment 3 by hbos@chromium.org, Jan 14 

#2: Yes in order not to block the default I'll be set sdpSemantics in the meantime. :)

Comment 4 by philipp....@googlemail.com, Jan 14 

when updating make sure you strip the a=msid:... before passing it to the plan-b peerconnection. See https://github.com/fippo/simulcast-playground/commit/9184439656deb498be3863546030c538a07b5abb
When the a=msid was in there it took preference over the a=ssrc:msid lines, resulting in only a single stream. No error was generated which is not very useful...

Comment 5 by hbos@chromium.org, Jan 14

Owner: orphis@chromium.org
►

Sign in to add a comment