ProfileSyncServiceBundle's IdentityTestEnvironment ivar should use its PrefService ivar |
||
Issue descriptionPSSBundle's IdentityTestEnvironment ivar currently uses its own PrefService instance. However, PSSBundle *also* has a PrefService instance that it uses. It seems like the latter PrefService instance should be passed to IdentityTestEnvironment for reasons of basic sanity. Presumably this could eventually otherwise blow up in someone's face in a pretty cryptic and irritating way.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/512c89f97ae9b66a598971c361997f9d7a9b2a1e commit 512c89f97ae9b66a598971c361997f9d7a9b2a1e Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Jan 14 12:30:56 2019 ProfileSyncServiceBundle's IdentityTestEnvironment ivar should use its PrefService ivar ProfileSyncServiceBundle's IdentityTestEnvironment ivar currently uses its own PrefService instance. However, ProfileSyncServiceBundle also has a PrefService instance that it uses. For the sake of consistency (and sanity) this CL passes PrefService instance of ProfileSyncServiceBundle to IdentityTestEnvironment. This was spotted by treib@ in https://chromium-review.googlesource.com/c/chromium/src/+/1403154/4#message-a650eebb1500314663a032dd63838b71c6943d17 R=treib@chromium.org CC=blundel@chromium.org BUG= 921037 ,1403154 Change-Id: I3b54fc4208c2fdd68d31481dceb0f9d8e49f6c4c Reviewed-on: https://chromium-review.googlesource.com/c/1408308 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#622430} [modify] https://crrev.com/512c89f97ae9b66a598971c361997f9d7a9b2a1e/components/browser_sync/profile_sync_test_util.cc
,
Jan 14
|
||
►
Sign in to add a comment |
||
Comment 1 by toniki...@chromium.org
, Jan 11Owner: toniki...@chromium.org
Status: Started (was: Available)