New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 921026 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Add UMA metrics to track errors reported from server

Project Member Reported by mastiz@google.com, Jan 11

Issue description

We've recently experienced user reports that involve error from the sync server (apparent throttling) like https://bugs.chromium.org/p/chromium/issues/detail?id=920112.

Let's add UMA metrics to log errors received from the sync server, so we can use UMA to slice and understand what has contributed to changes.
 
Owner: mastiz@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc6c745c687e366e6da39a6152d0d9e2c38469ad

commit cc6c745c687e366e6da39a6152d0d9e2c38469ad
Author: Mikel Astiz <mastiz@chromium.org>
Date: Mon Jan 14 21:54:04 2019

Add UMA for errors returned by sync server

This should allow investigate future issues and perhaps even do some
basic monitoring, for scenarios like users being throttled.

Bug: 921026,921588
Change-Id: Iff6036cd43863450f7561075cd8f9efb5a3a9f70
Reviewed-on: https://chromium-review.googlesource.com/c/1407084
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622620}
[modify] https://crrev.com/cc6c745c687e366e6da39a6152d0d9e2c38469ad/components/sync/engine_impl/syncer_proto_util.cc
[modify] https://crrev.com/cc6c745c687e366e6da39a6152d0d9e2c38469ad/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/cc6c745c687e366e6da39a6152d0d9e2c38469ad/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f638a1ea2d17c61303bf46706f3f5a1926ffa6b4

commit f638a1ea2d17c61303bf46706f3f5a1926ffa6b4
Author: Mikel Astiz <mastiz@chromium.org>
Date: Mon Jan 14 22:18:42 2019

Add UMA for sync server round trip latency

This should allow investigate future issues and also better understand
the headroom for improving latency of certain features.

Bug: 921026,902343
Change-Id: I05366ce4c08f102f47965bcbd4beb67d28352642
Reviewed-on: https://chromium-review.googlesource.com/c/1407085
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622628}
[modify] https://crrev.com/f638a1ea2d17c61303bf46706f3f5a1926ffa6b4/components/sync/engine_impl/syncer_proto_util.cc
[modify] https://crrev.com/f638a1ea2d17c61303bf46706f3f5a1926ffa6b4/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d18eac6936e3c36c7b93c3a4811205879545c3f6

commit d18eac6936e3c36c7b93c3a4811205879545c3f6
Author: Mikel Astiz <mastiz@chromium.org>
Date: Tue Jan 15 07:50:40 2019

Add UMA to break down sync GetUpdates() per datatype

This metric should allow investigating regressions like increased
traffic load to sync servers.

Bug: 921026,921588
Change-Id: I93668afceab67014e43af01c24c2342120ab23ea
Reviewed-on: https://chromium-review.googlesource.com/c/1409555
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622771}
[modify] https://crrev.com/d18eac6936e3c36c7b93c3a4811205879545c3f6/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/d18eac6936e3c36c7b93c3a4811205879545c3f6/components/sync/engine_impl/syncer_proto_util.cc
[modify] https://crrev.com/d18eac6936e3c36c7b93c3a4811205879545c3f6/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-72
Requesting merge for the three patches above, which add a new UMA metric each. These metrics are very relevant for rollouts and experiments in M72, including https://bugs.chromium.org/p/chromium/issues/approval?id=902704

All three patches are pretty simple and very unlikely to cause issues. The first two have been verified on latest canary.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 15

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment