New issue
Advanced search Search tips

Issue 921014 link

Starred by 1 user
Status: Fixed
Owner:
rhalavati@chromium.org
Closed: Jan 14
Cc:
mlamouri@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add App Name to Android media playing notification for pre-N.

Project Member Reported by rhalavati@google.com, Jan 11 
Android automatically adds app name to notifications from N.
After removing user data from Android notifications (crbug/629887), media playing notifications only says 'A site is playing media', and on pre-N devices there is no reference to Chrome.
App name and channel can be added as the title of these messages to resemble notifications for N and upward.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c102104dac91ddcee08970a78a1b666fbc56686

commit 1c102104dac91ddcee08970a78a1b666fbc56686
Author: rhalavati@chromium.org <rhalavati@chromium.org>
Date: Mon Jan 14 10:30:46 2019

Update Android media playing notifications in incognito.

Chrome app name (and channel) is not automatically shown on Android
prior to N and needs to be explicitly added. This is correct for media
playing notifications.

Bug:  921014 
Change-Id: If82b25464c2949c6807ac29f4595b9ac9431b7c2
Reviewed-on: https://chromium-review.googlesource.com/c/1404079
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622407}
[modify] https://crrev.com/1c102104dac91ddcee08970a78a1b666fbc56686/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/1c102104dac91ddcee08970a78a1b666fbc56686/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerNotificationTest.java

Comment 2 by rhalavati@google.com, Jan 14

Status: Fixed (was: Started)
►

Sign in to add a comment