New issue
Advanced search Search tips

Issue 921009 link

Starred by 1 user
Status: Fixed
Owner:
nickdi...@igalia.com
Closed: Jan 14
Cc:
msi...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 896640



Sign in to add a comment

[ozone/wayland] Event handling issues when multiple browser windows are open

Project Member Reported by nickdi...@igalia.com, Jan 11 
* Steps to reproduce:

1. Open chrome
2. Open new window (e.g: Ctrl+N)
3. Go back to 1st window open and click in the tab strip
4. Open a new tab in the 2nd window (e.g: clicking in the '+' button)

* Expected result:
A new tab should be opened in the 2nd browser window

* Actual result:
A new tab is created the tab in the 1st window

* GN Args:

enable_nacl=false
use_ozone=true
use_xkbcommon=true
use_system_minigbm=true
use_jumbo_build=true
is_debug=false
symbol_level=2
dcheck_always_on=true
cc_wrapper="ccache"

* System info:

Chrome Version: 73.0.3665.0 (Developer Build) (64-bit)
Running on:
Arch Linux - Kernel (LTS) 4.19.13
Mesa (libgbm): 18.3.1
Graphics card:  Intel Corporation UHD Graphics 620 (rev 07) (prog-if 00 [VGA controller])
Weston: 5.0.0
Gnome: 3.30.1
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c23e17dd76dcf3d2e145f2ad001f0b32955e157

commit 8c23e17dd76dcf3d2e145f2ad001f0b32955e157
Author: Nick Diego Yamane <nickdiego@igalia.com>
Date: Mon Jan 14 15:10:52 2019

[ozone/wayland] Fix event routing issue when multiple windows are open

Currently ozone wayland implementation uses singletons for bridging
wayland input objects (e.g: WaylandPointer, WaylandKeyboard, WaylandTouch),
each of them inject events into chromium event system. Additionally
they are currently responsible for controlling implicit_grab flag stored
on WaylandWindow instances.
This particular issue happens when new windows are created and the user
tries to trigger any action in browser UI (e.g: create new tab) of the
newly created window, what is currently leading to actions to be taken in
the wrong window (e.g: the new tab is open in the wrong window).
Under the hood, the bug happens because the implicit_grab flag
is not correctly unset for the window that lost focus. So the fix
consists on properly unsetting it on WaylandPointer.

Bug:  921009 
Change-Id: I25092fa211849f0345895b88681eaded52f09792
Reviewed-on: https://chromium-review.googlesource.com/c/1407011
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#622459}
[modify] https://crrev.com/8c23e17dd76dcf3d2e145f2ad001f0b32955e157/ui/ozone/platform/wayland/wayland_pointer.cc

Comment 2 by nickdi...@igalia.com, Jan 14

Blocking: 896640

Comment 3 by nickdi...@igalia.com, Jan 14

Status: Fixed (was: Started)
►

Sign in to add a comment