Port avatar_toolbar_button.cc away from GaiaCookieManagerService callbacks |
||||||
Issue descriptionIt should be ported to use equivalent observer methods in IdentityManager::Observer, instead of GaiaCookieManagerService::Observer See the 'Migration Guide' for specifics, including example CLs: https://docs.google.com/document/d/1bO7JsZE-xA8DSE18NeCZffbAnFZTo6vAtBCKsxaz4u8/edit#heading=h.y21mzvk0pm4c
,
Jan 11
,
Jan 11
,
Jan 14
I'm taking this
,
Jan 15
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fa3981d86535dfddfab2fc89ded02b5610b847f commit 1fa3981d86535dfddfab2fc89ded02b5610b847f Author: Sergio Villar Senin <svillar@igalia.com> Date: Wed Jan 16 10:48:56 2019 Port AvatarToolbarButton away from GaiaCookieManagerService callbacks It was observing the gaia cookie manager service to know whether the list of gaia accounts in the cookie jar has changed. That can be achieved observing IdentityManager as well. Bug: 921008 Change-Id: Icad5a14f1288346b97d4d8ccc1eb4c0a901eae3b Reviewed-on: https://chromium-review.googlesource.com/c/1408928 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#623187} [modify] https://crrev.com/1fa3981d86535dfddfab2fc89ded02b5610b847f/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/1fa3981d86535dfddfab2fc89ded02b5610b847f/chrome/browser/ui/views/profiles/avatar_toolbar_button.h
,
Jan 16
(6 days ago)
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lowell@chromium.org
, Jan 11Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug Pri-1
Owner: lowell@chromium.org