New issue
Advanced search Search tips

Issue 921005 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 859882



Sign in to add a comment

Port print_preview_handler.cc away from GaiaCookieManagerService callbacks

Project Member Reported by lowell@chromium.org, Jan 11

Issue description

It should be ported to use equivalent observer methods in IdentityManager::Observer, instead of GaiaCookieManagerService::Observer

See the 'Migration Guide' for specifics, including example CLs:
https://docs.google.com/document/d/1bO7JsZE-xA8DSE18NeCZffbAnFZTo6vAtBCKsxaz4u8/edit#heading=h.y21mzvk0pm4c
 
Blocking: 859882
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug Pri-1
Status: Available (was: Untriaged)
Owner: ----
Owner: hferre...@igalia.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc170142a1ca9706fb093f75ed41088e1b01d10b

commit fc170142a1ca9706fb093f75ed41088e1b01d10b
Author: Henrique Ferreiro <hferreiro@igalia.com>
Date: Tue Jan 15 12:36:26 2019

Port PrintPreviewHandler away from GaiaCookieManagerService

The CL changes PrintPreviewHandler to use IdentityManager APIs to deal
with the GAIA cookie.

Bug:  921005 
Change-Id: I2ab9ed6d49521a98ec7335349d1394355eaed716
Reviewed-on: https://chromium-review.googlesource.com/c/1409013
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622829}
[modify] https://crrev.com/fc170142a1ca9706fb093f75ed41088e1b01d10b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/fc170142a1ca9706fb093f75ed41088e1b01d10b/chrome/browser/ui/webui/print_preview/print_preview_handler.h

Status: Fixed (was: Started)

Sign in to add a comment