New issue
Advanced search Search tips

Issue 921004 link

Starred by 1 user
Status: Fixed
Owner:
jmad...@chromium.org
Closed: Jan 14
Cc:
crouleau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 920325



Sign in to add a comment

angle_perftests InterleavedAttributeDataBenchmark.Run/gl timing out on Windows 10 Intel bot

Project Member Reported by jmad...@chromium.org, Jan 11 
See https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf/1775

[ RUN      ] InterleavedAttributeDataBenchmark.Run/gl

Still waiting for the following processes to finish:

	".\angle_perftests.exe" --gtest_flagfile="c:\b\s\w\it86omro\scoped_dir316_29783\a1a618ca-2b10-4ce3-9834-a60f1315f22b.tmp" --shard-timeout=300 --single-process-tests --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it86omro\316_17988\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-retry-limit=0 --verbose

Still waiting for the following processes to finish:

	".\angle_perftests.exe" --gtest_flagfile="c:\b\s\w\it86omro\scoped_dir316_29783\a1a618ca-2b10-4ce3-9834-a60f1315f22b.tmp" --shard-timeout=300 --single-process-tests --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it86omro\316_17988\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-retry-limit=0 --verbose

Still waiting for the following processes to finish:

	".\angle_perftests.exe" --gtest_flagfile="c:\b\s\w\it86omro\scoped_dir316_29783\a1a618ca-2b10-4ce3-9834-a60f1315f22b.tmp" --shard-timeout=300 --single-process-tests --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it86omro\316_17988\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-retry-limit=0 --verbose

Still waiting for the following processes to finish:

	".\angle_perftests.exe" --gtest_flagfile="c:\b\s\w\it86omro\scoped_dir316_29783\a1a618ca-2b10-4ce3-9834-a60f1315f22b.tmp" --shard-timeout=300 --single-process-tests --test-launcher-jobs=1 --test-launcher-output="c:\b\s\w\it86omro\316_17988\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-retry-limit=0 --verbose

*RESULT InterleavedAttributeData_gl: wall_time= 15218.0360605771 us

*RESULT InterleavedAttributeData_gl: wall_time= 15185.3512244703 us

*RESULT InterleavedAttributeData_gl: wall_time= 15226.0836457425 us

[       OK ] InterleavedAttributeDataBenchmark.Run/gl (64794 ms)

[81/127] InterleavedAttributeDataBenchmark.Run/gl (TIMED OUT)

Going to skip this test in this configuration.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/92ee1f9f3032df3b95ef0f09a6e6ece6d4fcd737

commit 92ee1f9f3032df3b95ef0f09a6e6ece6d4fcd737
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Jan 11 13:40:07 2019

Suppress InterleavedAttributeDataBenchmark on GL.

This is timing out on Intel. Would be nice to narrow the suppression
but we don't have that check yet in perf tests.

Bug:  chromium:921004 
Change-Id: Icb8bf2d1222b9ff9790877dc051797a1291ad02b
Reviewed-on: https://chromium-review.googlesource.com/c/1406892
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/92ee1f9f3032df3b95ef0f09a6e6ece6d4fcd737/src/tests/perf_tests/InterleavedAttributeData.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f6cbb3b62a89f96cc7a4dccf898215bcf27fb05

commit 2f6cbb3b62a89f96cc7a4dccf898215bcf27fb05
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 11 15:07:21 2019

Roll src/third_party/angle 18af9a5a50c6..92ee1f9f3032 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/18af9a5a50c6..92ee1f9f3032


git log 18af9a5a50c6..92ee1f9f3032 --date=short --no-merges --format='%ad %ae %s'
2019-01-11 jmadill@chromium.org Suppress InterleavedAttributeDataBenchmark on GL.


Created with:
  gclient setdep -r src/third_party/angle@92ee1f9f3032

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:921004 
TBR=ynovikov@chromium.org

Change-Id: I8f6bf67d11be0715c4c4a45e9a9c1c71a3baee2f
Reviewed-on: https://chromium-review.googlesource.com/c/1406949
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#622006}
[modify] https://crrev.com/2f6cbb3b62a89f96cc7a4dccf898215bcf27fb05/DEPS
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/a3b64e867d2a78f5c0438d613618596ba89703f2

commit a3b64e867d2a78f5c0438d613618596ba89703f2
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Jan 11 19:39:05 2019

Fix skip for InterleavedAttributeDataBenchmark on GL.

Should be setting mSkipTest instead of calling abortTest().

Bug:  921004 
Change-Id: I7bead806eef0c7825348d509a9dce7ed1bf34825
Reviewed-on: https://chromium-review.googlesource.com/c/1407250
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/a3b64e867d2a78f5c0438d613618596ba89703f2/src/tests/perf_tests/InterleavedAttributeData.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e777a3d0786bd517e6e3184a94050196988209a0

commit e777a3d0786bd517e6e3184a94050196988209a0
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 11 21:34:28 2019

Roll src/third_party/angle 92ee1f9f3032..a3b64e867d2a (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/92ee1f9f3032..a3b64e867d2a


git log 92ee1f9f3032..a3b64e867d2a --date=short --no-merges --format='%ad %ae %s'
2019-01-11 jmadill@chromium.org Fix skip for InterleavedAttributeDataBenchmark on GL.


Created with:
  gclient setdep -r src/third_party/angle@a3b64e867d2a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:921004 
TBR=ynovikov@chromium.org

Change-Id: I16edab1b06bc98217739db64a9dd867dd2addce3
Reviewed-on: https://chromium-review.googlesource.com/c/1407102
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#622158}
[modify] https://crrev.com/e777a3d0786bd517e6e3184a94050196988209a0/DEPS

Comment 5 by jmad...@chromium.org, Jan 14

Status: Fixed (was: Started)
►

Sign in to add a comment