New issue
Advanced search Search tips

Issue 921000 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 921616
issue 480512



Sign in to add a comment

Remove legacy Telemetry features

Project Member Reported by perezju@chromium.org, Jan 11

Issue description

A number of Telemetry features have been obsolete for some time and should be removed.

Some of these include:
- legacy_page_test.LegacyPageTest (non-tracing based benchmarks)
- module.TimelineModel (TBMv1 model)
- timeline_based_metric.TimelineBasedMetric (used by TBMv1 benchmarks)


Assigning to myself as some of this is blocking the decoupling of metrics from Telemetry.
 
Blockedon: 480512
Components: Speed>Telemetry Tests>Telemetry
(Caleb: can you clarify the difference between the two Telemetry components?)
(I cannot clarify those differences, so I filed just  issue 921123  to merge the two.)
Labels: -Pri-3 Pri-2
I think this is at least a P2. Code health is a problem for Telemetry right now since there is a lot of dead code lying around and that makes it difficult to figure out how things actually work. Thanks for doing this work, Juan!
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff7e806617884c366aa53f7da19a0ca7cf0ce53

commit eff7e806617884c366aa53f7da19a0ca7cf0ce53
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jan 14 12:52:05 2019

[tools/perf] Remove dead code in old power measurements

LoadPower and QuiescentPower are no longer used anywhere.

Bug: 921000
Change-Id: Ibcd2b41cd15d88930cf4c7eb92e3618a9c07e006
Reviewed-on: https://chromium-review.googlesource.com/c/1406719
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622433}
[modify] https://crrev.com/eff7e806617884c366aa53f7da19a0ca7cf0ce53/tools/perf/measurements/power.py

Blockedon: 921616
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd

commit c9d39cb7402e371e19d1485f07270953c266d4cd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 16 02:43:37 2019

Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits)

https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e


git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s'
2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace
2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion"
2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac
2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py
2019-01-15 perezju@chromium.org Revert "Remove TagMap."
2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean
2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog.
2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old.
2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs.
2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier
2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric
2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion
2019-01-14 perezju@chromium.org Remove GetNetworkData methods
2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service
2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.


Created with:
  gclient setdep -r src/third_party/catapult@78448d90081e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208
TBR=sullivan@chromium.org

Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547
Reviewed-on: https://chromium-review.googlesource.com/c/1413252
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623062}
[modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 10 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Comment 11 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb4d4fb493857eaeaba08dea4a14b028a791956

commit 1eb4d4fb493857eaeaba08dea4a14b028a791956
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jan 17 12:46:16 2019

[tools/perf] Remove 'run_benchmark try' command

The command was removed about a year ago in:
https://chromium.googlesource.com/chromium/src/+/5d8ac50eb69e7ab99e0b476cb7bcfbe274671688

Bug: 921000
Change-Id: I3471ca93180a7ae88b5d2efbd9ac21b3056f367c
Reviewed-on: https://chromium-review.googlesource.com/c/1408976
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623657}
[delete] https://crrev.com/e386ec4cab781b3ba130762bc08532dc91124e85/tools/perf/core/trybot_command.py
[modify] https://crrev.com/1eb4d4fb493857eaeaba08dea4a14b028a791956/tools/perf/run_benchmark

Comment 13 by perezju@chromium.org, Jan 17 (5 days ago)

Note to self: Need to double-check, but it seems like we can also remove page.startup_url. Most pages now do the navigation to a URL themselves.
https://cs.chromium.org/search/?q=startup_url%5C%3D

Comment 14 by perezju@chromium.org, Jan 17 (5 days ago)

Status: Started (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a5ee85fe197ef9c9c098e22faea06b8e33d03e

commit b3a5ee85fe197ef9c9c098e22faea06b8e33d03e
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jan 17 13:24:31 2019

[tools/perf] Remove cros_benchmarks/tab_switching_measure.py

It's dead code now, as cros_tab_switching.typical_24 has been migrated
to TBMv2.

Also remove dead code in cros_utils.py no longer needed that used to
read results from chrome://histograms

Bug: 921000
Change-Id: I7e847694ef9a30a90c5efb8d1a4b65ddb1c47058
Reviewed-on: https://chromium-review.googlesource.com/c/1406724
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623665}
[modify] https://crrev.com/b3a5ee85fe197ef9c9c098e22faea06b8e33d03e/tools/perf/contrib/cros_benchmarks/cros_utils.py
[delete] https://crrev.com/3cfc052459afd1566023d1f600aabfb9e6051fb8/tools/perf/contrib/cros_benchmarks/tab_switching_measure.py

Project Member

Comment 16 by bugdroid1@chromium.org, Yesterday (43 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/21987aac84ecac52ff0458322bdfc384061c1d7b

commit 21987aac84ecac52ff0458322bdfc384061c1d7b
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jan 21 10:57:10 2019

[Telemetry] Remove page.startup_url feature

This feature is no longer used. Clients that need finer control on how
the Chrome browser is started (e.g. to provide a starting url other
than about:blank) can define their own shared state, like e.g.
startup.mobile benchmark does:
https://cs.chromium.org/chromium/src/tools/perf/benchmarks/startup_mobile.py?rcl=3167bc3d0ed7c18b706065ca6dac83d7deed5591&l=88

Bug: chromium:921000
Change-Id: I2f4e537fb1a127201ad44fe58b5fccb463475f28
Reviewed-on: https://chromium-review.googlesource.com/c/1418230
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/page/page_run_end_to_end_unittest.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/testing/story_set_smoke_test.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/backends/browser_backend.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/browser/browser.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/page/shared_page_state_unittest.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/browser/browser_options.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/page/__init__.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
[modify] https://crrev.com/21987aac84ecac52ff0458322bdfc384061c1d7b/telemetry/telemetry/page/shared_page_state.py

Project Member

Comment 17 by bugdroid1@chromium.org, Yesterday (42 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d96cc65ec37e190f097963c23ee7be29fc5e469

commit 9d96cc65ec37e190f097963c23ee7be29fc5e469
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Jan 21 11:51:25 2019

Roll src/third_party/catapult fab27dfe460a..21987aac84ec (1 commits)

https://chromium.googlesource.com/catapult.git/+log/fab27dfe460a..21987aac84ec


git log fab27dfe460a..21987aac84ec --date=short --no-merges --format='%ad %ae %s'
2019-01-21 perezju@chromium.org [Telemetry] Remove page.startup_url feature


Created with:
  gclient setdep -r src/third_party/catapult@21987aac84ec

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:921000
TBR=sullivan@chromium.org

Change-Id: Ic5d32f1966c0d73dd35f9ce5255de5242d369ffe
Reviewed-on: https://chromium-review.googlesource.com/c/1425018
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624558}
[modify] https://crrev.com/9d96cc65ec37e190f097963c23ee7be29fc5e469/DEPS

Sign in to add a comment