Regression: Media controls overflow menu options are not working when clicked on option label |
||||
Issue descriptionChrome Version : 73.0.3668.0 (Official Build) Revision 645ee4cd4de84c30b9746ffc90919f870cb8b245-refs/branch-heads/3668@{#1} 32/64 bit OS : Mac(10.13.6, 10.13.1, 10.14.3), Windows(7,8,10), Linux(14.04 LTS) Test URL : https://www.quirksmode.org/html5/videos/big_buck_bunny.mp4 What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click on 3 dot menu icon in video and click on the label(text) of 'Picture-in-Picture' in the list. 3. Observe. Actual Result : 'Picture-in-Picture' is not working when clicked on option label. (Note: Same behavior is observed for other options on overflow menu as well.) Expected Result : 'Picture-in-Picture' should work when clicked on option label. This is a regression issue broken in M-73 and below is the per-revision bisect information: Good Build : 73.0.3667.0 (Revision : 621407) Bad Build : 73.0.3668.0 (Revision : 621859) You are probably looking for a change made after 621413 (known good), but no later than 621414 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/99f96e85b1ab4b2896ee207eff264c069fb174d7..3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a Suspect: https://chromium.googlesource.com/chromium/src/+/3f7e5ce754f58f5fb3f02e748e6ae45dcffbb33a @CJ DiMeglio: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue can also be reproduced on following test URL's, - https://www.quirksmode.org/html5/tests/video.html - http://googlechrome.github.io/samples/picture-in-picture
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7dabda876150d9e46bc3d15f67d30478522536d commit e7dabda876150d9e46bc3d15f67d30478522536d Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Sat Jan 12 08:22:34 2019 Remove overflow_menu_container tab index = -1. This line was originally removed in https://chromium-review.googlesource.com/c/chromium/src/+/1401842, but due to a bad rebase, got added back in. Bug: 920996 Change-Id: I54c81ca2b5da6bf21471561ddbceee61c0072b18 Reviewed-on: https://chromium-review.googlesource.com/c/1407964 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#622299} [modify] https://crrev.com/e7dabda876150d9e46bc3d15f67d30478522536d/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
,
Jan 14
Update: Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3), Linux(14.04 LTS) OS using latest Canary build #73.0.3671.0 and the issue is fixed. Kindly refer attached screen cast. Thank you
,
Jan 15
,
Jan 15
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lethalantidote@chromium.org
, Jan 12