New issue
Advanced search Search tips

Issue 920975 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Check-boxes is not seen on installation dialogue box.

Project Member Reported by shru...@virtusa.com, Jan 11

Issue description

Chrome Version: 73.0.3668.0 (Official Build) 645ee4cd4de84c30b9746ffc90919f870cb8b245-refs/branch-heads/3668@{#1}(32/64-bit).
OS: Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and observe check-boxes of installation bubble.

Actual Result   :  Check-boxes is not  seen on installation dialogue box.
Expected Result :  Check-boxes should be seen on installation dialogue box.

This is a regression issue broken in M-73 and below is the bisect information:
Good Build : 73.0.3666.0(Revision:620998)
Bad Build : 73.0.3667.0(Revision:621406)

You are probably looking for a change made after 621349 (known good), but no later than 621350 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/338cc933e27c8c67e0df5193a1a885179f72ae75..dcca5677255f71457ba3918db68f322c8e31c9de

Suspect: https://chromium.googlesource.com/chromium/src/+/dcca5677255f71457ba3918db68f322c8e31c9de

@dbeam: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue  not seen on OS:Mac(10.13.1 , 10.13.6 , 10.14.3) and  Windows(7,8,8.1,10)

Kindly refer the attached screen-cast.
Thank You.
 
 
Expected Result.png
28.5 KB View Download
Actual Result.png
27.0 KB View Download
Cc: pucchakayala@chromium.org
Labels: ReleaseBlock-Beta
marking as RBB, please change if required
Status: Fixed (was: Assigned)
fairly sure https://crrev.com/c/1405724 will fix (which should be included in tomorrow's canary)
Update :
Retested the above issue and it is still reproducible on Linux(14.04 LTS) in Latest Canary #73.0.3672.0.
Kindly refer the attached screen-shot.
Thank You..
canarybehaviour.png
136 KB View Download
Status: Assigned (was: Fixed)
hey shrutij@, can you do the bisect again?

Comment 6 by robliao@chromium.org, Jan 17 (6 days ago)

Labels: Hotlist-DesktopUIConsider

Comment 7 by shru...@virtusa.com, Jan 17 (5 days ago)

Cc: lgrey@chromium.org
Update :
WRT to comment#5:

You are probably looking for a change made after 621390 (known good), but no later than 621391 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/64f9fa5153f9e73ca45193e54a01fa077e59131f..c301f0abb8821646d3acea02aa73425360157d86

Suspect: https://chromium.googlesource.com/chromium/src/+/c301f0abb8821646d3acea02aa73425360157d86

lgrey: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Re-bisected the issue three times got lgrey as suspect.
2.Re-bisected and got different suspect, sorry @dbeam for assigning you.

Thank You! 

Comment 8 by rbasuvula@google.com, Jan 17 (5 days ago)

Just to update:

This issue reproduce only on Ubuntu 14.04. Working fine in Ubuntu 16.04,Fedora 24& 25, Debian and Opensuse.

Thank You!

Comment 9 by lgrey@chromium.org, Jan 17 (5 days ago)

Cc: swarnasree.mukkala@chromium.org ajha@chromium.org
 Issue 922874  has been merged into this issue.

Comment 10 by dbeam@chromium.org, Jan 17 (5 days ago)

Cc: -lgrey@chromium.org dbeam@chromium.org
Owner: lgrey@chromium.org
r621391 seems quite possible

Comment 11 by jmukthavaram@chromium.org, Yesterday (43 hours ago)

Friendly ping!
Could you please provide any update on this issue as it has been marked as RBB and beta release is coming soon.

Thank You!

Comment 12 by lgrey@chromium.org, Today (16 hours ago)

I'll look at it today

Comment 13 by lgrey@chromium.org, Today (13 hours ago)

Cc: thomasanderson@chromium.org
thomasanderson@ is there a way I can set up options to repro this on a gLinux install? I'm assuming I need to trigger the GTK theme somehow?

Comment 14 by thomasanderson@chromium.org, Today (12 hours ago)

Yeah, you can enable the gtk theme in chrome://settings > Themes > Use GTK+

Comment 15 by lgrey@chromium.org, Today (11 hours ago)

Thanks!

Looks like this is what's getting returned from
GetBgColor(GtkButton#button.text-button.default.suggested-action");

Is there another constant you'd recommend using?

Comment 16 by thomasanderson@chromium.org, Today (11 hours ago)

Hm.. so it appears not all GTK themes actually style buttons with the "default" or "suggested-action" classes.  I'd recommend reverting the changes in native_theme_gtk.cc from c301f0abb8821646d3acea02aa73425360157d86

The ButtonBorderColor can stay the same. ProminentButtonDisabledColor could probably be GetBgColor("GtkButton#button.text-button:disabled")
Project Member

Comment 17 by bugdroid, Today (8 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71939a0b814a0e98d7a225c7b75b9b92ff2b89c1

commit 71939a0b814a0e98d7a225c7b75b9b92ff2b89c1
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Jan 22 21:42:29 2019

GTK theme: fix button colors

Bug: 920975
Change-Id: I93c442be6d76958db60d6840d21ca49192e1ae84
Reviewed-on: https://chromium-review.googlesource.com/c/1427443
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624934}
[modify] https://crrev.com/71939a0b814a0e98d7a225c7b75b9b92ff2b89c1/chrome/browser/ui/libgtkui/native_theme_gtk.cc

Sign in to add a comment