New issue
Advanced search Search tips

Issue 920972 link

Starred by 3 users
Status: Fixed
Owner:
manucornet@chromium.org
Closed: Jan 16
Cc:
ajha@chromium.org
pbos@chromium.org
manucornet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Launcher-Broken


Sign in to add a comment

Regression: Chopped Ripple effect is seen for app icons when we click & hold the icon in shelf

Project Member Reported by rkalavakuntla@chromium.org, Jan 11 
Chrome Version:73.0.3667.0/11562.0.0 dev channel Daisy,Kip,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> At shelf,click and hold any app icon and observe it ripple effect

Actual: Chopped Ripple effect is seen for app icons when we click & hold the icon in shelf
Expected: No such chopped ripple effect should be seen

This is a Regression issue as same works fine in 72.0.3626.49/11316.66.0 beta

Attached the screenshots for reference..
Actual chop.png
1.7 MB View Download
Expected.png
43.7 KB View Download

Comment 1 by newcomer@chromium.org, Jan 11

Owner: manucornet@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jamescook@chromium.org, Jan 12

Labels: Proj-Mash-SingleProcess
Drive-by: Does disabling SingleProcessMash in about:flags fix the problem? I wouldn't expect it to, but 3667 is the first chrome version that flipped the flag.

Comment 3 by manucornet@chromium.org, Jan 12 

I _think_ my CL 1395565 is likely the culprit here. I just finished a sizeable refactoring of shelf buttons. I'm going to fix this likely collateral damage.

Comment 4 by manucornet@chromium.org, Jan 13 

Issue 921201 has been merged into this issue.

Comment 5 by manucornet@chromium.org, Jan 14 

Hmm, actually my recent shelf button refactors seem to be innocent. But I doubt this is caused by SingleProcessMash. Will look some more.

Comment 6 by manucornet@chromium.org, Jan 14

Cc: manucornet@chromium.org
Owner: pbos@chromium.org
I've just confirmed that reverting CL 1367186 locally fixes the issue. @Peter can you take a look? Thanks!

Comment 7 by pbos@chromium.org, Jan 15 

Which button is this? Overriding ThatButtonClass::CreateInkDropMask() with { return nullptr; } should fix it. I'm not sure if that's the right place to fix it though. 

I assume it's not ShelfButton since that doesn't override any of the ink-drop effects?

Comment 8 by manucornet@chromium.org, Jan 15

Cc: pbos@chromium.org
Owner: manucornet@chromium.org
Status: Started (was: Assigned)
Okay, that sounds easy :-) I'll do that and send you the review. Thanks Peter.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f19badbc56ca0ba1318573bb7cad0b54c83425d

commit 1f19badbc56ca0ba1318573bb7cad0b54c83425d
Author: Manu Cornet <manucornet@chromium.org>
Date: Wed Jan 16 01:48:31 2019

CrOS Shelf: Fix shelf app button inkdrop mask

Bug:  920972 
Change-Id: Ia308fd77d3978be7bd354aba75c785fb08c85fe6
Reviewed-on: https://chromium-review.googlesource.com/c/1411341
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623001}
[modify] https://crrev.com/1f19badbc56ca0ba1318573bb7cad0b54c83425d/ash/shelf/shelf_app_button.cc
[modify] https://crrev.com/1f19badbc56ca0ba1318573bb7cad0b54c83425d/ash/shelf/shelf_app_button.h

Comment 10 by manucornet@chromium.org, Jan 16

Status: Fixed (was: Started)
►

Sign in to add a comment