Issue metadata
Sign in to add a comment
|
hana: Video on YouTube app is black frame in Chrome OS 11562.0.0 |
||||||||||||||||||||||
Issue descriptionAny video on YouTube app is black on hana. I found 11512.0.0 was fine. This problem doesn't happen on eve and kevin.
,
Jan 11
Assigned to johnylin@, who kindly look into this problem. Thanks!
,
Jan 11
Also reproducible on Elm 11562.0.0
,
Jan 15
johny is far from their machine now. As it takes more time to flush device, I will take over this issue.
,
Jan 15
This is caused by chrome uprev, 73.0.3666.0 -> 73.0.3667.0. https://chromium.googlesource.com/chromium/src/+log/73.0.3666.0..73.0.3667.0?n=10000
,
Jan 15
I find this is caused by https://chromium-review.googlesource.com/c/chromium/src/+/1368832. +jdarpinian@, +kbr@, may I please ask you to fix this issue ASAP?
,
Jan 15
I would like to investigate but I do not have an elm or hana device. Are other devices affected? Do you have a suggestion for how I could obtain an affected device for debugging?
,
Jan 15
I think this issue is reproducible only on MTK8173 devices. There are few MTK8173 devices besides hana and elm.
,
Jan 15
+textor Andrew, can you help assign an elm or hana to jdarpinian ? I'm not sure who on your team is responsible for allocations for those two older models.
,
Jan 15
,
Jan 15
marcheu@, hoegsberg@, dcastagna@: could we borrow one of these devices on which to reproduce this problem?
,
Jan 17
(6 days ago)
What is the update of this?
,
Jan 17
(6 days ago)
,
Jan 17
(5 days ago)
jdarpinian@ talked with the ChromeOS team and we should have a loaner device today on which to reproduce the problem.
,
Jan 17
(5 days ago)
,
Today
(11 hours ago)
I have a fix that I believe will work. I can't test it this week because I am out of the office, but I will submit it anyway and verify next week when I get back. http://crrev.com/c/1425728
,
Today
(9 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b270239f4ec4ab1a00332bdf3fda4bb5cb0eaecb commit b270239f4ec4ab1a00332bdf3fda4bb5cb0eaecb Author: James Darpinian <jdarpinian@chromium.org> Date: Tue Jan 22 20:56:19 2019 gpu: Fix format/internalformat confusion Several code paths in the command decoder were creating textures with format == internalformat. However, many internalformat values are not valid as format values. This was not checked before http://crrev.com/c/1368832 , but now it results in errors. This change calls TextureManager::ExtractFormatFromStorageFormat to get the correct format for the specified internalformat. Fixes video display in the YouTube Android app on some Chrome OS devices. Bug: 920967 , 809237 , 628064 Change-Id: I93c6449286094d895f45572fa0db5dbead1797ea Reviewed-on: https://chromium-review.googlesource.com/c/1425728 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#624907} [modify] https://crrev.com/b270239f4ec4ab1a00332bdf3fda4bb5cb0eaecb/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/b270239f4ec4ab1a00332bdf3fda4bb5cb0eaecb/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc [modify] https://crrev.com/b270239f4ec4ab1a00332bdf3fda4bb5cb0eaecb/gpu/command_buffer/service/texture_manager.cc
,
Today
(8 hours ago)
Should be fixed. Please reopen if not.
,
Today
(5 hours ago)
I verified this CL fixes the issue. Thanks. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hiroh@chromium.org
, Jan 11