New issue
Advanced search Search tips

Issue 920906 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 803774



Sign in to add a comment

Enable Signed Exchange behind Experimental Web Platform Features flag

Project Member Reported by ksakamoto@chromium.org, Jan 11

Issue description

We didn't that at first because of the security risks, and then we forgot to revisit it. But it's a good way to identify issues for big launches prior to being enabled globally.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cc9371439cf3caa3ca3ddd7d801fbae40d38811

commit 0cc9371439cf3caa3ca3ddd7d801fbae40d38811
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jan 11 06:26:53 2019

Enable Signed Exchange behind Experimental Web Platform Features flag

This patch enables Signed HTTP Exchange when the Experimental Web
Platform Features flag is on, in addition to the
--enable-features=SignedHTTPExchange flag.

Now sxg-origin-trial(-with-network-service) virtual tests run with
--stable-release-mode, so that the feature is disabled unless an OT
token is provided.

This patch also removes unused blink-side SignedHTTPExchange feature flag.

Bug:  920906 
Change-Id: Ic4a6bbef7086cead765fc4c11e767fd50772c1a7
Reviewed-on: https://chromium-review.googlesource.com/c/1405159
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621924}
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/content/child/runtime_features.cc
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/FlagExpectations/enable-blink-features=BlinkGenPropertyTrees
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/SlowTests
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/VirtualTestSuites
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/http/tests/misc/xhtml-expected.txt
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/README.txt
[modify] https://crrev.com/0cc9371439cf3caa3ca3ddd7d801fbae40d38811/third_party/blink/web_tests/virtual/sxg-origin-trial/http/tests/loading/sxg/README.txt
[delete] https://crrev.com/7cd680d601dadc27d26d1a6e17658028f49fab56/third_party/blink/web_tests/virtual/sxg/external/wpt/signed-exchange/README.txt
[delete] https://crrev.com/7cd680d601dadc27d26d1a6e17658028f49fab56/third_party/blink/web_tests/virtual/sxg/http/tests/devtools/sxg/README.txt
[delete] https://crrev.com/7cd680d601dadc27d26d1a6e17658028f49fab56/third_party/blink/web_tests/virtual/sxg/http/tests/loading/sxg/README.txt

Status: Fixed (was: Started)

Sign in to add a comment