New issue
Advanced search Search tips

Issue 920843 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Sparky/Bobba360: Headphone icon is displayed as default when device has dual internal mic

Project Member Reported by jennyz@google.com, Jan 11

Issue description

Chrome OS Version  :  ChromeOS R71-11123.0.0
Type of hardware   :  Bobba/Sparky, EVT

Please specify Area-* of the system to which this bug/feature applies (add
the label below).

What steps will reproduce the problem?
1. Expand the status area by shift+alt+s
2. Headphone icon is displayed, but system have not plug in headphone
    Please refer attached screenshot.

This happens on Sparky device with dual internal mics, like octopus.

What is the expected output?
No headphone icon show up as default when no headphone in.


How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

This refers to b/117306248

 
Cc: abodenha@chromium.org omrilio@chromium.org
Components: -UI>Shell
The issue is caused by dual internal mic(front and rear) making CrasAudioHandler:: has_alternative_input() returning true, which is not correct. The dual internal mic is shown as ONE internal input to user. 

https://cs.chromium.org/chromium/src/ash/system/audio/unified_volume_view.cc?g=0&l=150-151

The pending cl should fix the problem:
https://chromium-review.googlesource.com/c/chromium/src/+/1406297
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/457d1914c82df4b6376280533e92fc67a1c93271

commit 457d1914c82df4b6376280533e92fc67a1c93271
Author: Jenny Zhang <jennyz@chromium.org>
Date: Wed Jan 16 00:32:29 2019

Fix the issue for setting having audio alternative input/output.

Removed an invalid unit test case HandleOtherDeviceType: We should
not allow random device type to be handled as valid audio device.

Added a new unit test case to cover the scenario of this bug.

Bug:  920843 
Change-Id: I21e26641f61912dc8b5e5395624bbfa2c09ee10c
Reviewed-on: https://chromium-review.googlesource.com/c/1406297
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622927}
[modify] https://crrev.com/457d1914c82df4b6376280533e92fc67a1c93271/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/457d1914c82df4b6376280533e92fc67a1c93271/chromeos/audio/cras_audio_handler_unittest.cc

Comment 5 by jen...@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Untriaged)

Sign in to add a comment