New issue
Advanced search Search tips

Issue 920821 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Improve XR Browser Test polling

Project Member Reported by bsheedy@chromium.org, Jan 10 
Currently, the polling of things like JavaScript conditions is handled by a hacky for loop with sleeps. Now that I have a semblance of what base::RunLoop actually does, it should be possible to rewrite the polling so that repeatedly post (delayed?) tasks so that we don't block the main thread with polling.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/230934f8f0de640e8660217b6a5978e976cf94d9

commit 230934f8f0de640e8660217b6a5978e976cf94d9
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Jan 14 21:59:42 2019

Make XR browser test condition blocking safe

Replaces BlockOnConditionUnsafe in xr_browser_test.h/cc with
BlockOnCondition. This new approach uses RunLoop and task posting
instead of sleeps, so it should no longer have the potential to cause
issues by blocking the main thread from running.

Bug:  920821 
Change-Id: I72d155cc904ec0d41a0c3bdcb0bfa2ac6f5c035d
Reviewed-on: https://chromium-review.googlesource.com/c/1407961
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622621}
[modify] https://crrev.com/230934f8f0de640e8660217b6a5978e976cf94d9/chrome/browser/vr/test/xr_browser_test.cc
[modify] https://crrev.com/230934f8f0de640e8660217b6a5978e976cf94d9/chrome/browser/vr/test/xr_browser_test.h

Comment 2 by bsheedy@chromium.org, Today (7 hours ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment