New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 920800 link

Starred by 1 user
Status: Fixed
Owner:
█ zqzh...@chromium.org
Android MediaRouter only (left Chro...
Closed: Jan 17
Cc:
tguilbert@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

NPE crash in CafBaseMediaRouteProvider.onSessionStarted

Project Member Reported by zqzh...@chromium.org, Jan 10 
java.lang.NullPointerException: Attempt to read from field 'brp brN.b' on a null object reference
at org.chromium.chrome.browser.media.router.caf.CafBaseMediaRouteProvider.onSessionStarted	(CafBaseMediaRouteProvider.java:235 )
at org.chromium.chrome.browser.media.router.caf.CafBaseMediaRouteProvider.onSessionStarted	(CafBaseMediaRouteProvider.java:38 )
at com.google.android.gms.cast.framework.zzag.zzc	(zzag.java:15 )
at com.google.android.gms.cast.framework.zzaa.dispatchTransaction$514KOOBECHP6UQB45TNN6BQGC5P66PBC7D662RJ4E9NMIP1FDTPIUK31E9HMAR1R94KLK___0	(zzaa.java:18 )
at com.google.android.gms.internal.zzfl.onTransact	(zzfl.java:12 )
at android.os.Binder.transact	(Binder.java:635 )
at android.support.v7.widget.FastScroller$AnimatorListener.b	(FastScroller.java:15 )
at com.google.android.apps.chrome.icing.IcingController$1.doWhenConnected	(IcingController.java:111 )
at com.google.android.apps.chrome.icing.IcingController$1.doWhenConnected	(IcingController.java:87 )
at com.google.android.gms.wallet.firstparty.saveinstrument.zzf.a	(zzf.java:21 )
at com.google.android.apps.chrome.locale.LocaleManagerInternal.a	(LocaleManagerInternal.java:27 )
at com.android.webview.chromium.WebViewChromium$96.a	(WebViewChromium.java:49 )
at com.google.a.a.a.a.a.a.a	(a.java:6 )
at android.support.v7.widget.FastScroller$AnimatorUpdater.onTransact	(FastScroller.java:4 )
at android.os.Binder.transact	(Binder.java:635 )
at com.google.android.gms.internal.zzfk.zzb	(zzfk.java:20 )
at com.google.android.gms.cast.framework.zzm.zza	(zzm.java:20 )
at com.google.android.gms.cast.framework.CastSession$zza.onResult	(CastSession.java:22 )
at com.google.android.gms.common.api.internal.BasePendingResult$CallbackHandler.handleMessage	(BasePendingResult.java:10 )
at android.os.Handler.dispatchMessage	(Handler.java:106 )
at android.os.Looper.loop	(Looper.java:164 )
at android.app.ActivityThread.main	(ActivityThread.java:7000 )
at java.lang.reflect.Method.invoke	(Method.java )
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run	(RuntimeInit.java:441 )
at com.android.internal.os.ZygoteInit.main	(ZygoteInit.java:1408 )


It seems that SessionManagerListener.onSessionStarted gets called multiple times, while we cleaned up the internal state for the first one.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fc7f6c820adcb2b23f3c78af7085068f260ac5

commit 05fc7f6c820adcb2b23f3c78af7085068f260ac5
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Wed Jan 16 18:41:32 2019

Fix an NPE on session start

This CL fixes an NPE where
SessionManagerListener.onSessionStart() can be called twice for
one createRoute request. The fix is to guard the onSessionStart
logic in this condition.

Bug:  920800 
Change-Id: I483117ba69bd5d4e78faca4391e9f42d7c9cdbbc
Reviewed-on: https://chromium-review.googlesource.com/c/1407378
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623308}
[modify] https://crrev.com/05fc7f6c820adcb2b23f3c78af7085068f260ac5/chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafBaseMediaRouteProvider.java
[modify] https://crrev.com/05fc7f6c820adcb2b23f3c78af7085068f260ac5/chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafMediaRouteProvider.java
[modify] https://crrev.com/05fc7f6c820adcb2b23f3c78af7085068f260ac5/chrome/android/junit/src/org/chromium/chrome/browser/media/router/caf/CafBaseMediaRouteProviderTest.java
[modify] https://crrev.com/05fc7f6c820adcb2b23f3c78af7085068f260ac5/chrome/android/junit/src/org/chromium/chrome/browser/media/router/caf/CafMediaRouteProviderTest.java

Comment 2 by zqzh...@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment