Issue metadata
Sign in to add a comment
|
SingleProcessMash: Unable to Drag and drop files inside Files app and from Files app to other apps |
||||||||||||||||||||||
Issue descriptionChrome Version: 11558.0.0, 73.0.3667.0 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Download any images or files (2) Try to drag and drop files from one folder to other or from Files app to Gmail Expected Result: User should be able to drag and drop files from Files app Actual Result: Unable to drag and drop files from Files app How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? No workaround Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 11
Drag and drop is only broken with SingleProcessMash enabled.
,
Jan 11
,
Jan 11
I'll take this. sky/mukai - have either of you touched drag and drop recently? The last I remember erg@ was working on it, but that was a while ago.
,
Jan 11
I don't think anyone has touched it recently. Feel free to pass this my way if you are still working on the cluster fuzz issue.
,
Jan 11
,
Jan 11
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7689218b26bc62030d7b65fe138a88e64b19c8f6 commit 7689218b26bc62030d7b65fe138a88e64b19c8f6 Author: Scott Violet <sky@chromium.org> Date: Fri Jan 11 19:38:29 2019 chromeos: fixs dropping on webcontents Windows that want to receive drop events must call WindowTree::SetCanAcceptDrops(). This was only done for DesktopNativeWidgetAura's content-window by DesktopWindowTreeHostMus. A better approach is to implicitly call SetCanAcceptDrops() any time a DragDropDelegate is registered on a window. Going this route means DesktopWindowTreeHostMus doesn't need to explicitly call SetCanAcceptDrops() because DesktopNativeWidgetAura registers a DropDropDelegate. BUG= 920789 TEST=covered by test Change-Id: I3c350d51ba0258dafc70fcee98c694b7fc39ce0b Reviewed-on: https://chromium-review.googlesource.com/c/1407082 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622096} [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/services/ws/window_tree.cc [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/aura/client/drag_drop_delegate.cc [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/aura/client/drag_drop_delegate.h [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/aura/mus/window_port_mus_unittest.cc [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/aura/test/mus/test_window_tree.h [modify] https://crrev.com/7689218b26bc62030d7b65fe138a88e64b19c8f6/ui/views/mus/desktop_window_tree_host_mus.cc
,
Jan 11
,
Jan 14
Issue is verified in 11578.0.0, 73.0.3669.0
,
Jan 15
Not verified yet. Chrome has yet to roll
,
Jan 15
Issue is observed in 11587.0.0, 73.0.3669.0 when the SingleProcessMash Flag is enabled.
,
Jan 15
Issue 922257 has been merged into this issue.
,
Jan 15
spathangi, are you sure you hvae the version numbers right? What's the exact sequence you tried?
,
Jan 15
Never mind. I see the issue.
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c62a7eadc890246c2f5681659a9423387344eeee commit c62a7eadc890246c2f5681659a9423387344eeee Author: Scott Violet <sky@chromium.org> Date: Wed Jan 16 22:26:03 2019 chromeos: fix drag event coordinates DragDropControllerMus was not converting the coordinates correct. In fixing this it seems best to make this code consistent with the location of events passed to clients. BUG= 920789 TEST=none Change-Id: I5f1a86ac8038a8dd44dd66e7758821324028699f Reviewed-on: https://chromium-review.googlesource.com/c/1412022 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#623403} [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/content/renderer/mus/renderer_window_tree_client.h [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/drag_drop_delegate.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/drag_drop_delegate.h [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/public/mojom/window_tree.mojom [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/test_window_tree_client.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/test_window_tree_client.h [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/window_tree.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/window_tree.h [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/services/ws/window_tree_client_unittest.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/ui/aura/mus/drag_drop_controller_mus.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/ui/aura/mus/drag_drop_controller_mus.h [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/ui/aura/mus/drag_drop_controller_mus_unittest.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/c62a7eadc890246c2f5681659a9423387344eeee/ui/aura/mus/window_tree_client.h
,
Jan 16
(6 days ago)
Here's to hoping the latest fix completely addresses this. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by spathangi@chromium.org
, Jan 10